Page MenuHomeFreeBSD
Differential D43794

mixer(8): Allow full PCM device names as input for the -d option
ClosedPublic
Actions

Authored by christos on Feb 8 2024, 3:18 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Sep 8, 5:46 PM
Unknown Object (File)
Sun, Sep 8, 1:27 PM
Unknown Object (File)
Fri, Sep 6, 2:09 AM
Unknown Object (File)
Sat, Aug 31, 10:39 AM
Unknown Object (File)
Sat, Aug 31, 10:39 AM
Unknown Object (File)
Sat, Aug 31, 10:39 AM
Unknown Object (File)
Sat, Aug 31, 10:39 AM
Unknown Object (File)
Sat, Aug 31, 10:27 AM
View All 30 Files
Subscribers
imp

Details

Reviewers
markj
dev_submerge.ch
imp
Commits
rG7ff8cd094b73: mixer(8): Allow full PCM device names as input for the -d option
rG75be886e58dc: mixer(8): Allow full PCM device names as input for the -d option
Summary

The -d option is a wrapper around hw.snd.default_unit. Currently
mixer(8) expects the option argument to be just the unit's number (e.g
pcm0 -> 0). To avoid confusion, allow full device names of the form
"pcmN" as well.

While here, improve the -d option's description in the man page.

Sponsored by: The FreeBSD Foundation
MFC after: 2 weeks

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

christos created this revision.Feb 8 2024, 3:18 PM
Herald added a subscriber: imp. · View Herald TranscriptFeb 8 2024, 3:18 PM
christos requested review of this revision.Feb 8 2024, 3:18 PM
Harbormaster completed remote builds in B55866: Diff 134002.Feb 8 2024, 3:18 PM
christos added a parent revision: D43793: mixer(8): Improve error messsages and warnings.Feb 8 2024, 3:18 PM
christos added a child revision: D43795: mixer.8: Fix wrong sentence.
imp accepted this revision.Feb 8 2024, 4:01 PM
This revision is now accepted and ready to land.Feb 8 2024, 4:01 PM
christos updated this revision to Diff 134066.Feb 9 2024, 9:14 PM

Remove wrong usage info about being able to use both -d and -a at the same
time.

This revision now requires review to proceed.Feb 9 2024, 9:14 PM
Harbormaster completed remote builds in B55893: Diff 134066.Feb 9 2024, 9:14 PM
dev_submerge.ch accepted this revision.Feb 10 2024, 12:32 AM
This revision is now accepted and ready to land.Feb 10 2024, 12:32 AM
Closed by commit rG75be886e58dc: mixer(8): Allow full PCM device names as input for the -d option (authored by christos). · Explain WhyFeb 12 2024, 11:01 AM
This revision was automatically updated to reflect the committed changes.
christos added a commit: rG75be886e58dc: mixer(8): Allow full PCM device names as input for the -d option.
east_tutanota.de mentioned this in rG75be886e58dc: mixer(8): Allow full PCM device names as input for the -d option.Feb 22 2024, 7:18 PM
christos added a commit: rG7ff8cd094b73: mixer(8): Allow full PCM device names as input for the -d option.Feb 26 2024, 11:23 PM

Revision Contents
Changeset List

PathSize
usr.sbin/
mixer/
23 lines
6 lines

Diff 134175

View Options

usr.sbin/mixer/mixer.8

Loading...
View Options

usr.sbin/mixer/mixer.c

Loading...