Diffusion FreeBSD src repository 75be886e58dc

mixer(8): Allow full PCM device names as input for the -d option
Concern Raised75be886e58dc
Actions

Description

mixer(8): Allow full PCM device names as input for the -d option

The -d option is a wrapper around hw.snd.default_unit. Currently
mixer(8) expects the option argument to be just the unit's number (e.g
pcm0 -> 0). To avoid confusion, allow full device names of the form
"pcmN" as well.

While here, improve the -d option's description in the man page.

Sponsored by: The FreeBSD Foundation
MFC after: 2 weeks
Reviewed by: dev_submerge.ch, imp
Differential Revision: https://reviews.freebsd.org/D43794

Details

Auditors

east_tutanota.de

Provenance

christos

Authored on Feb 12 2024, 10:59 AM

Reviewer

dev_submerge.ch

Differential Revision

D43794: mixer(8): Allow full PCM device names as input for the -d option

Parents

rG09ba07011a62: mixer(8): Improve error messsages and warnings

Branches

Unknown

Tags

Unknown

Event Timeline

christos committed rG75be886e58dc: mixer(8): Allow full PCM device names as input for the -d option (authored by christos).Feb 12 2024, 11:00 AM

christos added an edge: D43794: mixer(8): Allow full PCM device names as input for the -d option.

hi i have a problem with mixer, it stopped changing bass and trebl. I was looking for a solution to the problem online and found a discussion of a recent edit on this forum : https://reviews.freebsd.org/D43794 . together with OSS using only sndiod. There are two devices, a built-in laptop card and a USB DAC. I discovered the problem not so long ago after the update.

-In the mixer for the built-in card, the bass and trebl controls stopped working.  volume and pcm work.
-in the mixer for USB DAC, on the contrary, volume and pcm work, bass and trebl do not work.

I have virtually no knowledge of code. but it seems to me that it could be related.

13.2-RELEASE-p9
OSS ABI 1302001

This commit now has outstanding concerns.Feb 22 2024, 7:18 PM

In rG75be886e58dc237b633104fc9cf8d7d1285e4003#620539, @east_tutanota.de wrote:
hi i have a problem with mixer, it stopped changing bass and trebl. I was looking for a solution to the problem online and found a discussion of a recent edit on this forum : https://reviews.freebsd.org/D43794 . together with OSS using only sndiod. There are two devices, a built-in laptop card and a USB DAC. I discovered the problem not so long ago after the update.
-In the mixer for the built-in card, the bass and trebl controls stopped working.  volume and pcm work.
-in the mixer for USB DAC, on the contrary, volume and pcm work, bass and trebl do not work.
I have virtually no knowledge of code. but it seems to me that it could be related.

13.2-RELEASE-p9
OSS ABI 1302001

Hello, while I'm not really familiar with the issue you're experiencing, I'm pretty sure this patch could not have been related to it. All the patch does is accept, say, "pcm0", in the -d option (as opposed to just passing the number), nothing else really. Also the patch is not present in 13.2-RELEASE.

christos mentioned this in rG7ff8cd094b73: mixer(8): Allow full PCM device names as input for the -d option.Feb 26 2024, 11:22 PM

christos mentioned this in D44556: pcm.4: Showcase default device change using mixer(8).Mar 29 2024, 3:57 PM