Differential D43782

rescue: Don't explicitly link with libsys
ClosedPublic
Actions

Authored by brooks on Feb 7 2024, 3:48 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, May 17, 11:18 AM

	Unknown Object (File)
	Mon, May 6, 7:18 AM

	Unknown Object (File)
	Sat, Apr 27, 7:52 AM

	Unknown Object (File)
	Sat, Apr 27, 7:52 AM

	Unknown Object (File)
	Sat, Apr 27, 7:41 AM

	Unknown Object (File)
	Sat, Apr 27, 6:15 AM

	Unknown Object (File)
	Apr 14 2024, 5:37 PM

	Unknown Object (File)
	Apr 8 2024, 10:33 PM

View All 20 Files

Subscribers

Details

Reviewers

kib
jrtc27
imp

Commits

rG82bebc793658: rescue: Don't explicitly link with libsys

Summary

libpthread contains the symbols we need when statically linked.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

brooks created this revision.Feb 7 2024, 3:48 PM

Herald added a subscriber: imp. · View Herald TranscriptFeb 7 2024, 3:48 PM

brooks requested review of this revision.Feb 7 2024, 3:48 PM

Harbormaster completed remote builds in B55846: Diff 133967.Feb 7 2024, 3:48 PM

brooks added a parent revision: D43781: libc: don't directly link libsys.Feb 7 2024, 3:48 PM

brooks added a child revision: D43783: libthr: filter rather than link with libsys.

Why was this added in the first place? I'd think it would have pulled it in via libc since we don't ask for it not to be included... hence the need not to need it here (so it makes sense to remove it).

This revision is now accepted and ready to land.Feb 7 2024, 7:53 PM

In D43782#998616, @imp wrote:

Why was this added in the first place? I'd think it would have pulled it in via libc since we don't ask for it not to be included... hence the need not to need it here (so it makes sense to remove it).

An earlier incarnation of the that patch failed to link (maybe with gcc12) and I missed that this was still here and test that it wasn't needed when I made last minute improvements to libthr.

Closed by commit rG82bebc793658: rescue: Don't explicitly link with libsys (authored by brooks). · Explain WhyFeb 7 2024, 9:10 PM

This revision was automatically updated to reflect the committed changes.

brooks added a commit: rG82bebc793658: rescue: Don't explicitly link with libsys.

Revision Contents
Changeset List

Path

Size

rescue/

rescue/

4 lines

Diff 133982

rescue/rescue/Makefile

Loading...