audio/pulseaudio: convert JACK option to a package
AcceptedPublic
Actions

Authored by lexi_le-fay.org on Jan 28 2024, 6:07 PM.

Details

Reviewers

arrowd

Group Reviewers

portmgr

Summary

Added a new 'jack' subpackage to audio/pulseaudio, which contains the JACK
input/output plugins.

This should be a fairly trivial and straightforward example of a subpackage,
since it's just a few loadable modules (.so files) with a dependency on
audio/jack.

Test Plan

Built the new packages, installed them, tried to play audio in
multimedia/musikcube, audio worked.

Diff Detail

Repository

R11 FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 55668
Build 52557: arc lint + arc unit

Event Timeline

lexi_le-fay.org requested review of this revision.Jan 28 2024, 6:07 PM

lexi_le-fay.org created this revision.

Harbormaster completed remote builds in B55667: Diff 133466.Jan 28 2024, 6:07 PM

arrowd added a subscriber: arrowd.Jan 28 2024, 6:14 PM

arrowd added inline comments.

audio/pulseaudio/Makefile
18	Why `?=` ?
20	This is default and shouldn't be needed.

dev_submerge.ch added a subscriber: dev_submerge.ch.Jan 28 2024, 6:19 PM

lexi_le-fay.org added inline comments.Jan 28 2024, 6:19 PM

audio/pulseaudio/Makefile
18	i couldn't find any documentation for subpackages, so i based this on https://reviews.freebsd.org/D43445 (appstream) which used ?=. i can change this if it's wrong.
20	okay, i'll removed that.