Page MenuHomeFreeBSD
Differential D43445

devel/appstream-compose: Make a subpackage of devel/appstream
ClosedPublic
Actions

Authored by arrowd on Jan 13 2024, 11:54 AM.
Tags
None
Referenced Files
F134800989: D43445.id132729.diff
Tue, Nov 4, 5:02 PM
F134800389: D43445.id.diff
Tue, Nov 4, 4:59 PM
F134799790: D43445.id132792.diff
Tue, Nov 4, 4:56 PM
F134799765: D43445.id132763.diff
Tue, Nov 4, 4:56 PM
F134799752: D43445.id132748.diff
Tue, Nov 4, 4:56 PM
F134799642: D43445.diff
Tue, Nov 4, 4:55 PM
F134781719: D43445.diff
Tue, Nov 4, 2:33 PM
Unknown Object (File)
Sun, Nov 2, 1:34 PM
View All Files
Subscribers
mat

Details

Reviewers
mat
Group Reviewers
portmgr
Commits
R11:f292ea6fb5fc: devel/appstream{,-qt,-compose}: Combine into a single port with SUBPACKAGES.

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

arrowd requested review of this revision.Jan 13 2024, 11:54 AM
arrowd created this revision.
Harbormaster completed remote builds in B55420: Diff 132728.Jan 13 2024, 11:54 AM
arrowd updated this revision to Diff 132729.Jan 13 2024, 11:57 AM
  • Flip a missing file into the subpackage.
Harbormaster completed remote builds in B55421: Diff 132729.Jan 13 2024, 11:57 AM
mat added a subscriber: mat.Jan 13 2024, 12:56 PM

What about adding the qt6 bits to the main port and only keep the qt5 as the slave port without flavors ?

That way when the qt5 version goes away, you only have to remove the qt5 slave port.

arrowd planned changes to this revision.Jan 13 2024, 5:21 PM

This is a great idea!

arrowd updated this revision to Diff 132748.Jan 14 2024, 8:41 AM
  • Add qt6 subpackage
  • Fix devel/appstream-qt slave to Qt 5.
Harbormaster completed remote builds in B55433: Diff 132748.Jan 14 2024, 8:41 AM
mat added a comment.Jan 14 2024, 8:55 AM

devel/appstream-qt should probably be moved to devel/appstream-qt5.

arrowd updated this revision to Diff 132749.Jan 14 2024, 9:05 AM
  • Move devel/appstream-qt to devel/appstream-qt5
  • Adjust the category Makefile
Harbormaster completed remote builds in B55434: Diff 132749.Jan 14 2024, 9:05 AM
arrowd updated this revision to Diff 132763.Jan 14 2024, 7:24 PM
  • Move SELF_DEPENDS to the bottom of the section.
Harbormaster completed remote builds in B55440: Diff 132763.Jan 14 2024, 7:24 PM
mat accepted this revision as: mat.Jan 14 2024, 8:52 PM

This looks good to me, but maybe someone else should have a look too.

This revision is now accepted and ready to land.Jan 14 2024, 8:52 PM
Closed by commit R11:f292ea6fb5fc: devel/appstream{,-qt,-compose}: Combine into a single port with SUBPACKAGES. (authored by arrowd). · Explain WhyJan 15 2024, 8:18 PM
This revision was automatically updated to reflect the committed changes.
arrowd added a commit: R11:f292ea6fb5fc: devel/appstream{,-qt,-compose}: Combine into a single port with SUBPACKAGES..
arrowd added a reverting change: R11:c6730766301d: Revert "devel/appstream{,-qt,-compose}: Combine into a single port with….Jan 24 2024, 3:23 PM
ivy mentioned this in D43637: audio/pulseaudio: convert JACK option to a package.Jan 28 2024, 6:19 PM

Revision Contents
Changeset List

PathSize
4 lines
devel/
3 lines
appstream-compose/
appstream-qt/
appstream-qt5/
22 lines
30 lines
appstream/
27 lines
7 lines
6 lines
53 lines
sysutils/
plasma5-discover/
2 lines

Diff 132792

View Options

MOVED

Loading...
View Options

devel/Makefile

Loading...
View Options

devel/appstream-compose/Makefile

Loading...
View Options

devel/appstream-compose/pkg-plist

Loading...
View Options

devel/appstream-qt/Makefile

Loading...
View Options

devel/appstream-qt/pkg-plist

Loading...
View Options

devel/appstream-qt5/Makefile

Loading...
View Options

devel/appstream-qt5/pkg-plist

Loading...
View Options

devel/appstream/Makefile

Loading...
View Options

devel/appstream/pkg-descr.compose

Loading...
View Options

devel/appstream/pkg-descr.qt6

Loading...
View Options

devel/appstream/pkg-plist

Loading...
View Options

sysutils/plasma5-discover/Makefile

Loading...