Modifications to elftc_set_timestamps manual page
Needs ReviewPublic
Actions

Authored by christopher.davidson_gmail.com on Jan 24 2024, 4:09 AM.

Details

Reviewers: None

Summary

The elftc_set_timestamps manual page linked to the incorrect utime(2) manual page, the manual page was updated to reflect the correct utime(3) reference.

Test Plan

N/A

Diff Detail

Repository

rG FreeBSD src repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 55710
Build 52599: arc lint + arc unit

Event Timeline

christopher.davidson_gmail.com created this revision.Jan 24 2024, 4:09 AM

Herald added a subscriber: imp. · View Herald TranscriptJan 24 2024, 4:09 AM

christopher.davidson_gmail.com requested review of this revision.Jan 24 2024, 4:09 AM

Harbormaster completed remote builds in B55585: Diff 133239.Jan 24 2024, 4:09 AM

Adding additional files to this revision, focus on:
zpool_status.8
zpool_iostat.8
zpool_wait.8
zpool_list.8

There was a misalignment of time(2) -> time(1)

Herald added a subscriber: delphij. · View Herald TranscriptJan 24 2024, 4:48 AM

Harbormaster completed remote builds in B55586: Diff 133240.Jan 24 2024, 4:48 AM

christopher.davidson_gmail.com retitled this revision from elftc_set_timestamps.3 modification to update from utime(2) -> utime(3) to elftc_set_timestamps.3 modification to update from utime(2) -> utime(3) and zpool.Jan 24 2024, 4:51 AM

christopher.davidson_gmail.com edited the summary of this revision. (Show Details)

christopher.davidson_gmail.com retitled this revision from elftc_set_timestamps.3 modification to update from utime(2) -> utime(3) and zpool to Modifications to elftc_set_timestampes, zpool_status, zpool_iostat, zpool_wait, zpool_list.

It would be better to submit to the upstream https://github.com/openzfs/zfs/ as well, or first.

Thank you for the recommendation. I will fork the openzfs work on github and submit the zfs related items to that

I have uploaded a pull request to here: https://github.com/openzfs/zfs/pull/15823

which would lead me to believe that the next actions would be to "remove" these from the commit and handle in that request above.

Beyond the zfs ones, are there any issues with the elftc_set_timestamps updates? to possible move this to a pull request.

In D43566#994456, @christopher.davidson_gmail.com wrote:

I have uploaded a pull request to here: https://github.com/openzfs/zfs/pull/15823

Thanks and I saw it is merged. I think we can contact @mm for pulling in from OpenZFS.

which would lead me to believe that the next actions would be to "remove" these from the commit and handle in that request above.

Beyond the zfs ones, are there any issues with the elftc_set_timestamps updates? to possible move this to a pull request.

I am not quite sure if I understand these. Can you explain this more to me?

Summary: Removed the zpool items from this review as they have been addressed.

Addressed in pull request:https://github.com/openzfs/zfs/pull/15823

Harbormaster completed remote builds in B55710: Diff 133607.Jan 30 2024, 4:20 PM

christopher.davidson_gmail.com retitled this revision from Modifications to elftc_set_timestampes, zpool_status, zpool_iostat, zpool_wait, zpool_list to Modifications to elftc_set_timestampes.Jan 30 2024, 4:24 PM

christopher.davidson_gmail.com edited the summary of this revision. (Show Details)

christopher.davidson_gmail.com retitled this revision from Modifications to elftc_set_timestampes to Modifications to elftc_set_timestamps manual page.

This is meant to just isolate to the elf timestamp man page..

I am not 100% sure why it was deleting the zpool stuff from the repo but this is in mistake and the arc utility does not "see" that the files are in fact there.

Please let me know if there is anything else required and request your patience as I am learning these tools through these submissions.

In D43566#995950, @lwhsu wrote:

In D43566#994456, @christopher.davidson_gmail.com wrote:

I have uploaded a pull request to here: https://github.com/openzfs/zfs/pull/15823

Thanks and I saw it is merged. I think we can contact @mm for pulling in from OpenZFS.

which would lead me to believe that the next actions would be to "remove" these from the commit and handle in that request above.

Beyond the zfs ones, are there any issues with the elftc_set_timestamps updates? to possible move this to a pull request.

I am not quite sure if I understand these. Can you explain this more to me?

Please disregard the comment. I was trying to, quite poorly, to explain it would be best to remove the zpool-* stuff from this commit. I took care of that component of it.

Thank you for loopin in @mm into the thread for openzfs considerations.