Page MenuHomeFreeBSD

kcmp: Add a manual page
ClosedPublic

Authored by markj on Jan 23 2024, 3:35 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jul 8, 10:03 AM
Unknown Object (File)
Mon, Jul 8, 10:00 AM
Unknown Object (File)
Mon, Jul 8, 9:41 AM
Unknown Object (File)
Mon, Jul 8, 9:32 AM
Unknown Object (File)
Fri, Jul 5, 11:26 AM
Unknown Object (File)
Thu, Jun 27, 7:37 PM
Unknown Object (File)
Thu, Jun 27, 5:49 PM
Unknown Object (File)
Thu, Jun 27, 5:49 PM
Subscribers

Details

Summary

Sponsored by: The FreeBSD Foundation

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markj requested review of this revision.Jan 23 2024, 3:35 PM
emaste added inline comments.
lib/libc/sys/kcmp.2
4

Standard copyright is just "The FreeBSD Foundation" (no Inc)

36

not just file descriptors though, "kernel objects" maybe?
the fd table or signal handler table aren't fds

51

is "access to" correct? or is it "reference" the same kernel object?

216

Do we want to list the known ones that are not implemented?
KCMP_IO, KCMP_SYSVSEM, KCMP_FS?

Also KCMP_FILEOBJ is FreeBSD-specific?

markj marked 2 inline comments as done.

Handle Ed's feedback.

lib/libc/sys/kcmp.2
4

Oops, thanks. I copied this from sigfastblock.2 btw. In fact this "Inc" appears in quite a few FF copyright lines.

51

Yes, "reference" is more accurate.

216

I don't see much purpose in keeping a list? An interested reader can compare the two man pages.

We should mention somewhere that the caller must have the privilege to debug both pid1 and pid2.

lib/libc/sys/kcmp.2
40

You need userspace unistd.h to get the prototype.

124
150

The order is internally defined by kernel and is stable until system reboots.

markj marked 4 inline comments as done.

Handle review comments from kib.

This revision is now accepted and ready to land.Jan 23 2024, 9:21 PM

Thank you for working on this.

This revision was automatically updated to reflect the committed changes.