contrib/kyua: Merge vendor import

[bofh]

Summary

This patch merges the vendor import of kyua. However we need to add the file contrib/kyua/utils/process/executor_pid_test.cpp in the build system which will be done after this has been imported.
`

[markj]

Looks sane, thanks. I ran through the test suite locally with this change and didn't spot any new problems.

Let us know if you'd like review of the merge commit itself, i.e., push the merge somewhere that we can inspect it.

[lwhsu]

contrib/kyua/.cirrus.yml

2

I feel this file can be skipped and be in FREEBSD-Xlist, but not a strong preference.

[markj]

contrib/kyua/.cirrus.yml

2

Yeah, I can't see any reason to include this in main.

[bofh]

In D43475#991153, @markj wrote:

Looks sane, thanks. I ran through the test suite locally with this change and didn't spot any new problems.

My tests did not yield any errors.

Let us know if you'd like review of the merge commit itself, i.e., push the merge somewhere that we can inspect it.

It's a bit difficult pushing a merge commit somewhere else specially Github. As the vendor trees are actually not present in a Github fork. If you want I can create custom branch and apply the patch manually and push it to a new branch if it helps.

[bofh]

contrib/kyua/.cirrus.yml

2

Personally speaking I really do not like them at all. I have proposed earlier about removing all CI related files from the contrib parts as what happens is if we manually create a fork in GH all of the CI start hits up on the first commit. So I can remove the entire file too if all of you prefer the same.

[markj]

In D43475#991166, @bofh wrote:

In D43475#991153, @markj wrote:

Looks sane, thanks. I ran through the test suite locally with this change and didn't spot any new problems.

My tests did not yield any errors.

Let us know if you'd like review of the merge commit itself, i.e., push the merge somewhere that we can inspect it.

It's a bit difficult pushing a merge commit somewhere else specially Github. As the vendor trees are actually not present in a Github fork. If you want I can create custom branch and apply the patch manually and push it to a new branch if it helps.

I don't see what's preventing you from pushing the kyua vendor branch to a github fork. And that's not necessary anyway, if you just push the merge commit somewhere, that's sufficient.

contrib/kyua/.cirrus.yml

2

Well, I see now that other kyua CI files are in main, e.g., contrib/kyua/travis.yml. It doesn't hurt I suppose, so like Li-Wen I don't have a strong preference.

[bofh]

In D43475#991153, @markj wrote:

I don't see what's preventing you from pushing the kyua vendor branch to a github fork. And that's not necessary anyway, if you just push the merge commit somewhere, that's sufficient.

Here is the branch https://github.com/5u623l20/freebsd-src/tree/kyua-merge

I will keep the .cirrus.yml for now then.

[markj]

In D43475#991182, @bofh wrote:

In D43475#991153, @markj wrote:

I don't see what's preventing you from pushing the kyua vendor branch to a github fork. And that's not necessary anyway, if you just push the merge commit somewhere, that's sufficient.

Here is the branch https://github.com/5u623l20/freebsd-src/tree/kyua-merge

This should be a merge commit. See https://docs.freebsd.org/en/articles/committers-guide/#vendor-import-git for details.

Specifically, you should git subtree merge -P contrib/kyua anon/vendor/kyua and push the result. Please go ahead with that, but the commit you pushed to github should not be pushed to FreeBSD.