Page MenuHomeFreeBSD

sdhci_fsl_fdt: add support for LS1088A
Changes PlannedPublic

Authored by bz on Jan 15 2024, 8:09 PM.
Tags
None
Referenced Files
Unknown Object (File)
May 12 2024, 2:17 PM
Unknown Object (File)
May 10 2024, 5:15 PM
Unknown Object (File)
Feb 19 2024, 10:14 PM
Unknown Object (File)
Feb 18 2024, 7:24 PM
Unknown Object (File)
Feb 10 2024, 9:44 PM
Unknown Object (File)
Jan 18 2024, 8:26 PM
Unknown Object (File)
Jan 18 2024, 1:45 AM
Subscribers

Details

Reviewers
jceel
imp
Group Reviewers
arm64
Summary

Add the SoC specific data structure make sdhci work on the LS1088A.
It is currently unclear whether the SDHCI_FSL_TUNING_ERRATUM_TYPE2
errata setting is actually needed.

MFC after: 14 days

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 55449
Build 52338: arc lint + arc unit

Event Timeline

bz requested review of this revision.Jan 15 2024, 8:09 PM
This revision is now accepted and ready to land.Jan 17 2024, 4:03 PM

What does it do if you don't use SDHCI_FSL_TUNING_ERRATUM_TYPE2 ?

In D43461#991392, @manu wrote:

What does it do if you don't use SDHCI_FSL_TUNING_ERRATUM_TYPE2 ?

I'll try at some point but currently I am trying to make sure HS200 is stable.

As another note:

  • removing the last quirk seems to make not change at hs200
  • With either I still cannot get it stable on a 2nd board; create a GPT scheme; reboot and have MBR; sometimes I/O errors, sometime CORRUPT GPT on the disk-XXXXX but not on the sdda0. Not sure as to how-much this is sdhci_fsl or MMCCAM at this point but I'll keep looking.

Wish the NXP LS1088A errata was public.

In D43461#992623, @bz wrote:

As another note:

  • removing the last quirk seems to make not change at hs200
  • With either I still cannot get it stable on a 2nd board; create a GPT scheme; reboot and have MBR; sometimes I/O errors, sometime CORRUPT GPT on the disk-XXXXX but not on the sdda0. Not sure as to how-much this is sdhci_fsl or MMCCAM at this point but I'll keep looking.

Easy to test with GENERIC

Wish the NXP LS1088A errata was public.

bz planned changes to this revision.Jan 23 2024, 11:28 PM

I cannot get this stable even with mmc(4) GENERIC (no MMCCAM).
Starts to make me wonder if the clocks are right ... but I cross-checked those again to the LS1088ARM.pdf (still not updated).

sys/dev/sdhci/sdhci_fsl_fdt.c
241

That is not needed without SDHCI_FSL_MISSING_VCCQ_REG.