Page MenuHomeFreeBSD
Differential D43410

databases/sqldeveloper: add NO_ARCH=yes
ClosedPublic
Actions

Authored by vvd on Jan 12 2024, 4:46 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jan 13, 4:36 PM
Unknown Object (File)
Nov 2 2024, 7:37 PM
Unknown Object (File)
Oct 24 2024, 3:54 PM
Unknown Object (File)
Sep 16 2024, 12:56 PM
Unknown Object (File)
Sep 14 2024, 10:21 PM
Unknown Object (File)
Sep 9 2024, 1:59 AM
Unknown Object (File)
Sep 8 2024, 1:02 PM
Unknown Object (File)
Sep 8 2024, 11:16 AM
View All 33 Files
Subscribers
bapt
diizzy

Details

Reviewers
arrowd
adamw
tcberner
bapt
Commits
R11:257ccb0437e3: databases/sqldeveloper: add NO_ARCH=yes and remove JavaFX native libraries for…
Summary

stage-qa wrote this warning:

pkg-static: DEVELOPER_MODE: Notice: arch "FreeBSD:13:amd64" -- no architecture specific files found:
**** could this package use a wildcard architecture?

Tested in poudriere with NO_ARCH=yes: build without errors and without this warning.

Need opinions from more experienced ports maintainers.

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

vvd requested review of this revision.Jan 12 2024, 4:46 AM
vvd created this revision.
bapt added a subscriber: bapt.Jan 12 2024, 7:46 AM

NO_ARCH is wrong because the package can and should only be installed on amd64, just stage-qa, does not know about the linux abi

bapt requested changes to this revision.Jan 12 2024, 7:46 AM
This revision now requires changes to proceed.Jan 12 2024, 7:46 AM
bapt added a comment.Jan 12 2024, 7:49 AM

oups sorry this is java not linux

bapt resigned from this revision.Jan 12 2024, 7:49 AM
This revision now requires review to proceed.Jan 12 2024, 7:49 AM
arrowd accepted this revision.Jan 12 2024, 8:12 AM
This revision is now accepted and ready to land.Jan 12 2024, 8:12 AM
vvd updated this revision to Diff 132661.Jan 12 2024, 9:02 AM

Removed JavaFX native libraries for linux, osx and windows.
Reduced Flat size from 545MiB to 422MiB.

This revision now requires review to proceed.Jan 12 2024, 9:02 AM
arrowd accepted this revision.Jan 12 2024, 9:23 AM

Even better now!

This revision is now accepted and ready to land.Jan 12 2024, 9:23 AM
Closed by commit R11:257ccb0437e3: databases/sqldeveloper: add NO_ARCH=yes and remove JavaFX native libraries for… (authored by vvd). · Explain WhyJan 12 2024, 9:38 AM
This revision was automatically updated to reflect the committed changes.
vvd added a commit: R11:257ccb0437e3: databases/sqldeveloper: add NO_ARCH=yes and remove JavaFX native libraries for….

Revision Contents
Changeset List

PathSize
databases/
sqldeveloper/
5 lines
98 lines

Diff 132663

View Options

databases/sqldeveloper/Makefile

Loading...
View Options

databases/sqldeveloper/pkg-plist

Loading...