Page MenuHomeFreeBSD

Replace cdevpriv_dtr_t with d_priv_dtor_t typedef.
ClosedPublic

Authored by jhb on Dec 1 2015, 10:50 PM.
Tags
None
Referenced Files
F133392887: D4340.id10673.diff
Sat, Oct 25, 10:57 AM
F133392884: D4340.id10654.diff
Sat, Oct 25, 10:57 AM
F133392880: D4340.id.diff
Sat, Oct 25, 10:57 AM
F133392878: D4340.id10653.diff
Sat, Oct 25, 10:57 AM
F133392875: D4340.id10652.diff
Sat, Oct 25, 10:57 AM
F133358790: D4340.diff
Sat, Oct 25, 4:30 AM
Unknown Object (File)
Tue, Oct 14, 9:54 AM
Unknown Object (File)
Thu, Oct 9, 9:02 PM
Subscribers
None

Details

Summary

The cdevpriv_dtr_t typedef was not able to be used in a function prototype
like the various d_*_t typedefs since it declared a function pointer rather
than a function. Add a new d_priv_dtor_t typedef that declares the function
and can be used as a function prototype. The previous typedef wasn't
useful outside of the cdevpriv implementation, so retire it.

The name d_priv_dtor_t was chosen to be more consistent with cdev methods
since it is commonly used in place of d_close_t even though it is not a
direct pointer in struct cdevsw.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1375
Build 1380: arc lint + arc unit

Event Timeline

jhb retitled this revision from to Replace cdevpriv_dtr_t with d_priv_dtor_t typedef..
jhb updated this object.
jhb edited the test plan for this revision. (Show Details)
jhb added reviewers: kib, imp.
jhb edited edge metadata.

Fix the one use of the typedef.

jhb edited edge metadata.

Tidy.

imp edited edge metadata.
This revision is now accepted and ready to land.Dec 1 2015, 11:11 PM
kib edited edge metadata.
This revision was automatically updated to reflect the committed changes.