Page MenuHomeFreeBSD
Differential D43000

jevents: fix bootstrapping on Linux with Clang 16
ClosedPublic
Actions

Authored by arichardson on Dec 11 2023, 11:00 PM.
Tags
None
Referenced Files
F133077881: D43000.id131266.diff
Wed, Oct 22, 6:45 PM
Unknown Object (File)
Tue, Oct 21, 1:37 AM
Unknown Object (File)
Sat, Oct 18, 6:22 PM
Unknown Object (File)
Sat, Oct 18, 4:57 AM
Unknown Object (File)
Thu, Oct 16, 11:48 PM
Unknown Object (File)
Thu, Oct 16, 10:33 PM
Unknown Object (File)
Thu, Oct 16, 1:42 AM
Unknown Object (File)
Fri, Sep 26, 5:30 AM
View All 73 Files
Subscribers
None

Details

Reviewers
imp
jrtc27
emaste
Commits
rGf16e205c6fb9: jevents: fix bootstrapping on Linux with Clang 16
rG8cb8aca83f6c: jevents: fix bootstrapping on Linux with Clang 16
rG60e845ceef25: jevents: fix bootstrapping on Linux with Clang 16
Summary

It appears that Clang 16 errors by default for the mismatched function
pointer types that are triggered by the fts callback.
Add an ifdef to handle this case.

Test Plan

builds now

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

arichardson requested review of this revision.Dec 11 2023, 11:00 PM
arichardson created this revision.
Harbormaster completed remote builds in B54899: Diff 131266.Dec 11 2023, 11:00 PM
imp accepted this revision.Dec 11 2023, 11:09 PM

The commit message should say that GLIBC has different function prototypes for its version of FTS callback than BSD does a little more explicitly.

This revision is now accepted and ready to land.Dec 11 2023, 11:09 PM
emaste accepted this revision.Dec 12 2023, 12:12 AM

Agree with @imp.

Closed by commit rG60e845ceef25: jevents: fix bootstrapping on Linux with Clang 16 (authored by arichardson). · Explain WhyDec 12 2023, 5:15 AM
This revision was automatically updated to reflect the committed changes.
arichardson added a commit: rG60e845ceef25: jevents: fix bootstrapping on Linux with Clang 16.
jrtc27 added a commit: rG8cb8aca83f6c: jevents: fix bootstrapping on Linux with Clang 16.May 2 2024, 8:11 PM
jrtc27 added a commit: rGf16e205c6fb9: jevents: fix bootstrapping on Linux with Clang 16.

Revision Contents
Changeset List

PathSize
lib/
libpmc/
pmu-events/
4 lines

Diff 131271

View Options

lib/libpmc/pmu-events/jevents.c

Loading...