UEFI: combine GetMemoryMap and ExitBootServices and retry on error

[emaste]

Summary

Glue together calls to GetMemoryMap(), ExitBootServices() and storage of (now up-to-date) MODINFOMD_EFI_MAP metadata within a single function.

That new function -bi_add_efi_data_and_exit()- uses space previously allocated in bi_load_efi_data() to store the memory map (it will fail if that space is too short). It handles re-calling GetMemoryMap() once to update the map key if necessary. Finally, if ExitBootServices() is successful, it stores the memory map and its header as MODINFOMD_EFI_MAP metadata.

ExitBootServices() calls are now done earlier, from within arch-independent bi_load() code. The patch has only been tested on amd64 ; tests on other archs are welcome ! I have not modified i386 code as it seems to have its own bi_load() and separate code, but it may be good to make it benefit from supporting map key re-fetching if ExitBootServices() fails.

Submitted by: Ganael LAPLANCHE
PR: 202455

With minor style(9) whitespace tweaks

[kib]

sys/boot/efi/loader/bootinfo.c

245 ↗

(On Diff #10537)

Space after if before (, excessive ()s. But why this check at all ?

258 ↗

(On Diff #10537)

May be, print 'Try %d: ExitBootServices() returned %d\n", i, ...);' to make it more clean to user that this is transient.

[emaste]

Update as suggested by @kib

[emaste]

sys/boot/efi/loader/bootinfo.c

258 ↗

(On Diff #10892)

I moved the printf out of the loop completely, since it's not an error or warning case.

[imp]

I think this is OK. I have some patches I need to get into the tree that let you use runtime services, but that's more of a need to communicate the memory map to UEFI...