bsdinstall generate opt_osname.h in osname
ClosedPublic
Actions

Authored by sjg on Dec 7 2023, 1:19 AM.

Details

Reviewers

stevek
jrtc27

Commits

rG83d0b8c089d8: bsdinstall generate opt_osname.h in include

Summary

This allows the subdirs that do more work to run in parallel

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

sjg created this revision.Dec 7 2023, 1:19 AM

Herald added a subscriber: imp. · View Herald TranscriptDec 7 2023, 1:19 AM

sjg requested review of this revision.Dec 7 2023, 1:19 AM

Harbormaster completed remote builds in B54841: Diff 131107.Dec 7 2023, 1:19 AM

Rename osname to include

But git-arc cannot cope with that and does not seem to support
specifying the review id.

Harbormaster completed remote builds in B54842: Diff 131108.Dec 7 2023, 1:43 AM

missed SUBDIR_DEPEND_

Harbormaster completed remote builds in B54843: Diff 131109.Dec 7 2023, 1:45 AM

One nit, and I assume you've verified that opt_osname.h does now have the right contents?

Otherwise looks good thanks, though don't have the knowledge to review the Makefile.depend parts (beyond wondering why this seemingly-simple structure requires a manually written one).

This revision is now accepted and ready to land.Dec 7 2023, 2:17 AM

In D42947#979246, @jrtc27 wrote:

One nit, and I assume you've verified that opt_osname.h does now have the right contents?

Yes.

#define OSNAME "FreeBSD"

Otherwise looks good thanks, though don't have the knowledge to review the Makefile.depend parts (beyond wondering why this seemingly-simple structure requires a manually written one).

The reason is that in DIRDEPS_BUILD usr.sbin/bsdinstall itself does not actually do anything only leaf dirs are visited,
but it is handy to have a Makefile.depend there for doing test builds of this dir and its subdirs.

Closed by commit rG83d0b8c089d8: bsdinstall generate opt_osname.h in include (authored by sjg). · Explain WhyDec 7 2023, 2:36 AM

This revision was automatically updated to reflect the committed changes.

sjg added a commit: rG83d0b8c089d8: bsdinstall generate opt_osname.h in include.