Page MenuHomeFreeBSD
Differential D42652

dd(1): Consolidate character sets
Needs ReviewPublic
Actions

Authored by gbe on Nov 17 2023, 5:31 PM.
Tags
None
Referenced Files
Unknown Object (File)
Oct 2 2024, 7:24 PM
Unknown Object (File)
Sep 8 2024, 8:09 AM
Unknown Object (File)
Sep 8 2024, 7:22 AM
Unknown Object (File)
Aug 21 2024, 4:23 PM
Unknown Object (File)
May 8 2024, 6:51 AM
Unknown Object (File)
May 8 2024, 6:51 AM
Unknown Object (File)
May 8 2024, 4:01 AM
Unknown Object (File)
Apr 6 2024, 3:03 PM
View All 16 Files
Subscribers
None

Details

Reviewers
imp
jilles
emaste
Summary

The "ibm" and "oldibm" tables are identical, because POSIX just
standardized the table from V7. Nobody, including the original authors,
seems to have noticed this, so merge them.

Obtained from: NetBSD
MFC after: 2 weeks

Test Plan

build dd

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 54497
Build 51386: arc lint + arc unit

Event Timeline

gbe requested review of this revision.Nov 17 2023, 5:31 PM
gbe created this revision.
Harbormaster completed remote builds in B54497: Diff 130260.Nov 17 2023, 5:31 PM
imp added inline comments.Nov 17 2023, 6:34 PM
bin/dd/conv_tab.c
60

There's 5 tables now, now?

gbe marked an inline comment as done.Dec 17 2023, 3:22 PM
gbe added inline comments.
bin/dd/conv_tab.c
60

I would think the comment is correct. Only the conversion from _POSIX and _32V would be merged.

gbe marked an inline comment as done.Feb 24 2024, 1:13 PM

@imp, are there any issues that prevent that differential from landing?

Revision Contents
Changeset List

PathSize
bin/
dd/
4 lines
38 lines
2 lines

Diff 130260

View Options

bin/dd/args.c

Loading...
View Options

bin/dd/conv_tab.c

Loading...
View Options

bin/dd/extern.h

Loading...