sysutils/edk2: set IO port range properly for bhyve

[corvink]

Summary

Bhyve uses an io port range of [ 0x2000, 0x10000 ] [1]. At the moment,
EDKII is using a subset of this range [ 0xC000, 0x10000 ] [2]. Even
though the EDKII range doesn't exeeds the bhyve range, it's causing
issues on some guests like OpenBSD. We don't know why it's causing
issues yet. However, using the same IO port range in EDKII fixes the
issue.

[1] https://github.com/freebsd/freebsd-src/blob/82ea0132c8b17a7a6067c8a36c6434e587ede6de/usr.sbin/bhyve/pci_emul.c#L133-L134
[2] https://github.com/tianocore/edk2/blob/fb044b7fe893a4545995bfe2701fd38e593355d9/OvmfPkg/Bhyve/PlatformPei/Platform.c#L156-L157

PR: 274389

[corvink]

• set EDKII IO port range to [ 0x2000, 0x10000 ] too

[manu]

In D42627#972655, @corvink wrote:

• set EDKII IO port range to [ 0x2000, 0x10000 ] too

Did you forget a patch ? I don't see any diff between your two diffs

[corvink]

In D42627#972662, @manu wrote:

In D42627#972655, @corvink wrote:

• set EDKII IO port range to [ 0x2000, 0x10000 ] too

Did you forget a patch ? I don't see any diff between your two diffs

Old diff:

-  PciIoBase = 0xC000;
-  PciIoSize = 0x4000;
+  PciIoBase = 0x2000;
+  PciIoSize = 0xC000;

New diff:

-  PciIoBase = 0xC000;
-  PciIoSize = 0x4000;
+  PciIoBase = 0x2000;
+  PciIoSize = 0xE000;

In the new diff PciIoSize is 0xE000 now.

[manu]

In D42627#972663, @corvink wrote:

In D42627#972662, @manu wrote:

In D42627#972655, @corvink wrote:

• set EDKII IO port range to [ 0x2000, 0x10000 ] too

Did you forget a patch ? I don't see any diff between your two diffs

Old diff:

-  PciIoBase = 0xC000;
-  PciIoSize = 0x4000;
+  PciIoBase = 0x2000;
+  PciIoSize = 0xC000;

New diff:

-  PciIoBase = 0xC000;
-  PciIoSize = 0x4000;
+  PciIoBase = 0x2000;
+  PciIoSize = 0xE000;

In the new diff PciIoSize is 0xE000 now.

Ah yeah, I should have read more carefully :)
I'm ok with this as long as this will be upstreamed and that the patch will be dropped in a future update.

[corvink]

In D42627#972664, @manu wrote:

I'm ok with this as long as this will be upstreamed and that the patch will be dropped in a future update.

I'm going to upstream this patch when someone has confirmed that it solves https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=274389.

[markj]

I had to change the patch to use DOS line endings. With that, I'm able to boot an OpenBSD guest after applying this patch and rebuilding edk2-bhyve.

Will this change make it into the package set used for 14.0-RELEASE? That is, will it go into the quarterly branch?

[manu]

In D42627#972796, @markj wrote:

I had to change the patch to use DOS line endings. With that, I'm able to boot an OpenBSD guest after applying this patch and rebuilding edk2-bhyve.

Will this change make it into the package set used for 14.0-RELEASE? That is, will it go into the quarterly branch?

This can go in quarterly easily if you want, but it will not be in the release_0 packages as it's already taggued, but since those packages are only used for DVD it's ok.

[markj]

In D42627#972798, @manu wrote:

In D42627#972796, @markj wrote:

I had to change the patch to use DOS line endings. With that, I'm able to boot an OpenBSD guest after applying this patch and rebuilding edk2-bhyve.

Will this change make it into the package set used for 14.0-RELEASE? That is, will it go into the quarterly branch?

This can go in quarterly easily if you want

If doing so means that 14.0 users will be able to run OpenBSD (or other affected OSs) in bhyve without hitting the regression, then yes please. :)

[corvink]

• fix newline style

[corvink]

FYI: I've send this patch to EDKII https://edk2.groups.io/g/devel/topic/patch_v1_1_1_ovmfpkg_bhyve/102646333