Page MenuHomeFreeBSD

tty: properly check character position when handling IUTF8 backspaces
ClosedPublic

Authored by bnovkov on Nov 13 2023, 4:49 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Aug 30, 5:47 PM
Unknown Object (File)
Fri, Aug 30, 5:47 PM
Unknown Object (File)
Fri, Aug 30, 5:46 PM
Unknown Object (File)
Fri, Aug 30, 5:46 PM
Unknown Object (File)
Fri, Aug 16, 9:17 PM
Unknown Object (File)
Tue, Aug 13, 8:07 PM
Unknown Object (File)
Wed, Aug 7, 9:20 PM
Unknown Object (File)
Wed, Aug 7, 6:33 PM
Subscribers

Details

Summary

This patch fixes PR 275009.

The tty_rubchar code handling backspaces for UTF8 characters didn't properly check whether the beginning of the current line was reached.
This resulted in a kernel panic in ttyinq_unputchar when prodded with certain malformed UTF8 sequences.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

This revision is now accepted and ready to land.Nov 13 2023, 5:53 PM

Upload diff with full context.

This revision now requires review to proceed.Nov 13 2023, 5:56 PM
This revision is now accepted and ready to land.Nov 13 2023, 5:58 PM