Page MenuHomeFreeBSD
Differential D42564

tty: properly check character position when handling IUTF8 backspaces
ClosedPublic
Actions

Authored by bnovkov on Nov 13 2023, 4:49 PM.
Tags
None
Referenced Files
F106141925: D42564.diff
Thu, Dec 26, 2:23 AM
Unknown Object (File)
Wed, Dec 11, 8:55 AM
Unknown Object (File)
Nov 21 2024, 2:49 AM
Unknown Object (File)
Nov 21 2024, 2:37 AM
Unknown Object (File)
Nov 19 2024, 10:36 PM
Unknown Object (File)
Nov 17 2024, 11:46 AM
Unknown Object (File)
Nov 17 2024, 11:44 AM
Unknown Object (File)
Nov 17 2024, 11:40 AM
View All 68 Files
Subscribers
imp

Details

Reviewers
christos
Commits
rG31f6cfca851f: tty: properly check character position when handling IUTF8 backspaces
rG8647fe60b8c3: tty: properly check character position when handling IUTF8 backspaces
rGae8387cc818a: tty: properly check character position when handling IUTF8 backspaces
rGc6d7be214811: tty: properly check character position when handling IUTF8 backspaces
Summary

This patch fixes PR 275009.

The tty_rubchar code handling backspaces for UTF8 characters didn't properly check whether the beginning of the current line was reached.
This resulted in a kernel panic in ttyinq_unputchar when prodded with certain malformed UTF8 sequences.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

bnovkov created this revision.Nov 13 2023, 4:49 PM
Herald added a subscriber: imp. · View Herald TranscriptNov 13 2023, 4:49 PM
bnovkov requested review of this revision.Nov 13 2023, 4:49 PM
bnovkov edited the summary of this revision. (Show Details)Nov 13 2023, 5:23 PM
christos accepted this revision.Nov 13 2023, 5:53 PM
This revision is now accepted and ready to land.Nov 13 2023, 5:53 PM
christos added a comment.Nov 13 2023, 5:54 PM

Please provide a full diff.

bnovkov updated this revision to Diff 130025.Nov 13 2023, 5:56 PM

Upload diff with full context.

This revision now requires review to proceed.Nov 13 2023, 5:56 PM
christos accepted this revision.Nov 13 2023, 5:58 PM
This revision is now accepted and ready to land.Nov 13 2023, 5:58 PM
Closed by commit rGc6d7be214811: tty: properly check character position when handling IUTF8 backspaces (authored by bnovkov, committed by christos). · Explain WhyNov 13 2023, 6:05 PM
This revision was automatically updated to reflect the committed changes.
christos added a commit: rGc6d7be214811: tty: properly check character position when handling IUTF8 backspaces.
christos added a commit: rGae8387cc818a: tty: properly check character position when handling IUTF8 backspaces.Nov 20 2023, 4:55 PM
christos added a commit: rG8647fe60b8c3: tty: properly check character position when handling IUTF8 backspaces.Nov 20 2023, 4:58 PM
markj added a commit: rG31f6cfca851f: tty: properly check character position when handling IUTF8 backspaces.Dec 5 2023, 6:28 PM

Revision Contents
Changeset List

PathSize
sys/
kern/
4 lines

Diff 130025

View Options

sys/kern/tty_ttydisc.c

Loading...