ibcore: Add dependency on "netstack"

[khng]

Summary

Obtained from: Juniper Networks, Inc.

[jhibbits]

There's no "netstack" module in the FreeBSD kernel. I think a DECLARE_MODULE needs added, probably to sys/net/if.c, before this works.

[zlei]

In D42453#968771, @jhibbits wrote:

There's no "netstack" module in the FreeBSD kernel. I think a DECLARE_MODULE needs added, probably to sys/net/if.c, before this works.

The "netstack" is built into kernel. Maybe the following one?

MODULE_DEPEND(ibcore, kernel, __FreeBSD_version, __FreeBSD_version, maxver);

See also sys/sys/module.h https://cgit.freebsd.org/src/tree/sys/sys/module.h#n140

#define	DECLARE_MODULE_WITH_MAXVER(name, data, sub, order, maxver)	\
	MODULE_DEPEND(name, kernel, __FreeBSD_version,			\
	    __FreeBSD_version, maxver);					\
	MODULE_METADATA(_md_##name, MDT_MODULE, &data, __XSTRING(name));\
	SYSINIT(name##module, sub, order, module_register_init, &data);	\
	struct __hack

#ifdef KLD_TIED
#define	DECLARE_MODULE(name, data, sub, order)				\
	DECLARE_MODULE_WITH_MAXVER(name, data, sub, order, __FreeBSD_version)
#else
#define	DECLARE_MODULE(name, data, sub, order)							\
	DECLARE_MODULE_WITH_MAXVER(name, data, sub, order, MODULE_KERNEL_MAXVER)
#endif

sys/ofed/drivers/infiniband/core/ib_device.c

1086

Any problems without a module dependency to "netstack" ?

[jhibbits]

In D42453#970257, @zlei wrote:

In D42453#968771, @jhibbits wrote:

There's no "netstack" module in the FreeBSD kernel. I think a DECLARE_MODULE needs added, probably to sys/net/if.c, before this works.

The "netstack" is built into kernel. Maybe the following one?

MODULE_DEPEND(ibcore, kernel, __FreeBSD_version, __FreeBSD_version, maxver);

There's already an implicit MODULE_DEPEND() on kernel for all modules.

sys/ofed/drivers/infiniband/core/ib_device.c

1086

No problems in FreeBSD. This is to support alternative (loadable) netstacks, as we use at Juniper.