Page MenuHomeFreeBSD

Check to see if ZFS is available before invoking bectl
Needs ReviewPublic

Authored by gordon on Nov 2 2023, 11:36 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jun 22, 12:26 AM
Unknown Object (File)
May 18 2026, 7:33 AM
Unknown Object (File)
May 15 2026, 3:31 PM
Unknown Object (File)
May 6 2026, 1:23 AM
Unknown Object (File)
Apr 30 2026, 4:39 PM
Unknown Object (File)
Apr 20 2026, 11:29 PM
Unknown Object (File)
Apr 18 2026, 9:53 PM
Unknown Object (File)
Apr 15 2026, 8:19 PM
Subscribers

Details

Summary

bectl will unconditionally load the ZFS module. For systems not running ZFS, we shouldn't be spuriously loading ZFS just because we ran freebsd-update install.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

gordon added reviewers: emaste, kevans.

We have a fix for this already in the tree; bectl/libbe was never meant to trigger loading of zfs.ko in the first place.

We could bring it back to stable/12, too, if we need to... it's been soaking for quite a while.

We have a fix for this already in the tree; bectl/libbe was never meant to trigger loading of zfs.ko in the first place.

We could bring it back to stable/12, too, if we need to... it's been soaking for quite a while.

I went ahead and tested it on and brought it back to stable/12 in case you're trying to errata this or something...

I mostly just noticed this on a fresh UFS based install. Do you think it would be good to have both checks (one in bectl and one in freebsd-update)?

I mostly just noticed this on a fresh UFS based install. Do you think it would be good to have both checks (one in bectl and one in freebsd-update)?

IMO no since this was really anomalous behavior, but I'd grab a second opinion from our resident freebsd-update expert @emaste to be sure...