Page MenuHomeFreeBSD

Check to see if ZFS is available before invoking bectl
Needs ReviewPublic

Authored by gordon on Nov 2 2023, 11:36 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 10 2024, 9:40 PM
Unknown Object (File)
Feb 3 2024, 8:18 AM
Unknown Object (File)
Jan 18 2024, 10:09 PM
Unknown Object (File)
Jan 16 2024, 1:01 AM
Unknown Object (File)
Jan 7 2024, 11:21 AM
Unknown Object (File)
Jan 1 2024, 1:20 PM
Unknown Object (File)
Dec 23 2023, 3:09 AM
Unknown Object (File)
Dec 15 2023, 8:23 AM
Subscribers

Details

Summary

bectl will unconditionally load the ZFS module. For systems not running ZFS, we shouldn't be spuriously loading ZFS just because we ran freebsd-update install.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

gordon added reviewers: emaste, kevans.

We have a fix for this already in the tree; bectl/libbe was never meant to trigger loading of zfs.ko in the first place.

We could bring it back to stable/12, too, if we need to... it's been soaking for quite a while.

We have a fix for this already in the tree; bectl/libbe was never meant to trigger loading of zfs.ko in the first place.

We could bring it back to stable/12, too, if we need to... it's been soaking for quite a while.

I went ahead and tested it on and brought it back to stable/12 in case you're trying to errata this or something...

I mostly just noticed this on a fresh UFS based install. Do you think it would be good to have both checks (one in bectl and one in freebsd-update)?

I mostly just noticed this on a fresh UFS based install. Do you think it would be good to have both checks (one in bectl and one in freebsd-update)?

IMO no since this was really anomalous behavior, but I'd grab a second opinion from our resident freebsd-update expert @emaste to be sure...