libpfctl: be more tolerant of kernel extensions
ClosedPublic
Actions

Authored by kp on Oct 28 2023, 10:38 PM.

Details

Reviewers

zlei

Group Reviewers

network

Commits

rGc17db80ddd57: libpfctl: be more tolerant of kernel extensions
rG228ae54114e1: libpfctl: be more tolerant of kernel extensions
rG2b1eb63fc9c6: libpfctl: be more tolerant of kernel extensions

Summary

Allow the kernel to supply more array elements than expected, but cut
off when we hit what we think the maximum is. This will improve forward
compatibility (i.e. old userspace with newer kernel).

MFC after: 1 week
Sponsored by: Orange Business Services

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 54196
Build 51086: arc lint + arc unit

Event Timeline

kp created this revision.Oct 28 2023, 10:38 PM

Herald added a subscriber: imp. · View Herald TranscriptOct 28 2023, 10:38 PM

kp requested review of this revision.Oct 28 2023, 10:38 PM

kp added a child revision: D42393: pf: support SCTP-specific timeouts.

Harbormaster completed remote builds in B54196: Diff 129489.Oct 28 2023, 10:38 PM

Looks good to me.

lib/libpfctl/libpfctl.c
156	In case `elems < maxelems` then `numbers[]` may have uninitialized value. But that is out of the scope of this change.

This revision is now accepted and ready to land.Oct 30 2023, 1:57 PM

Closed by commit rG2b1eb63fc9c6: libpfctl: be more tolerant of kernel extensions (authored by kp). · Explain WhyOct 31 2023, 3:05 PM

This revision was automatically updated to reflect the committed changes.

kp added a commit: rG2b1eb63fc9c6: libpfctl: be more tolerant of kernel extensions.

kp added a commit: rG228ae54114e1: libpfctl: be more tolerant of kernel extensions.Nov 7 2023, 3:48 PM

kp added a commit: rGc17db80ddd57: libpfctl: be more tolerant of kernel extensions.

Revision Contents
Changeset List

Path

Size

lib/

libpfctl/

libpfctl.c

3 lines

Diff 129489

View Options

libpfctl: be more tolerant of kernel extensionsClosedPublicActions