string: implement strsep() through strcspn()
ClosedPublic
Actions

Authored by fuz on Oct 24 2023, 4:41 AM.

Details

Reviewers

mjg
kib

Commits

rG265fb89aba2a: lib/libc/amd64/string: implement strsep() through strcspn()
rG8dc035482310: share/man/man7/simd.7: document amd64 SIMD use for strsep()
rGfd2ecd91aeee: lib/libc/amd64/string: implement strsep() through strcspn()
rG75cb202698a6: share/man/man7/simd.7: document amd64 SIMD use for strsep()

Summary

The strsep() function is basically strcspn() with extra steps.
On amd64, we now have an optimised implementation of strcspn(),
so instead of implementing the inner loop manually, just call
into the optimised routine.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

fuz created this revision.Oct 24 2023, 4:41 AM

Herald added a subscriber: imp. · View Herald TranscriptOct 24 2023, 4:41 AM

fuz requested review of this revision.Oct 24 2023, 4:41 AM

Harbormaster completed remote builds in B54146: Diff 129275.Oct 24 2023, 4:41 AM

This revision was not accepted when it landed; it landed in state Needs Review.Dec 25 2023, 2:26 PM

Closed by commit rG75cb202698a6: share/man/man7/simd.7: document amd64 SIMD use for strsep() (authored by fuz). · Explain Why

This revision was automatically updated to reflect the committed changes.

fuz added a commit: rG75cb202698a6: share/man/man7/simd.7: document amd64 SIMD use for strsep().

fuz added a commit: rGfd2ecd91aeee: lib/libc/amd64/string: implement strsep() through strcspn().

fuz added a commit: rG8dc035482310: share/man/man7/simd.7: document amd64 SIMD use for strsep().Jan 24 2024, 7:45 PM

fuz added a commit: rG265fb89aba2a: lib/libc/amd64/string: implement strsep() through strcspn().

Revision Contents
Changeset List

Path

Size

share/

man/

man7/

simd.7

3 lines

Diff 131814

View Options

lib/libc/amd64/string: implement strsep() through strcspn()ClosedPublicActions