Page MenuHomeFreeBSD

Add myself as ports committer, update mentor/mentee
ClosedPublic

Authored by michaelo on Oct 19 2023, 2:02 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jun 24, 9:51 PM
Unknown Object (File)
Mon, Jun 10, 3:09 AM
Unknown Object (File)
Mon, Jun 10, 3:05 AM
Unknown Object (File)
Apr 30 2024, 4:23 PM
Unknown Object (File)
Mar 11 2024, 1:09 PM
Unknown Object (File)
Mar 11 2024, 1:09 PM
Unknown Object (File)
Mar 11 2024, 1:00 PM
Unknown Object (File)
Mar 8 2024, 1:25 AM
Subscribers

Details

Reviewers
jrm
otis

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

Could you also share your commit log here?

share/misc/committers-ports.dot
682

We need a newline here.

From Git:

$ git show --stat
commit b9f1cb8b9b2c2b84ba37cfb3b6780ed7f2949fcd (HEAD -> michaelo)
Author: Michael Osipov <michaelo@FreeBSD.org>
Date:   2023-10-19 15:53:11 +0200

    Add myself as ports committer, update mentor/mentee

    This completes step 5 from Committer's Guide.

    Approved by:            jrm (mentor)
    Differential Review:    https://reviews.freebsd.org/D42293

 share/misc/committers-ports.dot | 4 ++++
 1 file changed, 4 insertions(+)
This revision is now accepted and ready to land.Oct 19 2023, 2:31 PM
In D42293#965000, @jrm wrote:

lgtm

Good, I am not able to commit to src, please?!

Patch: {F69627452}

You should be able to commit to src. Have you tried? If so, it's probably a git hook that's preventing you. Can you show the output?

One other thing that's not a blocker here. Your diffs don't have any context for some reason. Are you using arc diff --create... or git arc... (if you use freebsd-git-devtools from devel/freebsd-git-devtools)? If so, I'll ask someone from phabric-admin@ why there is no context.

In D42293#965015, @jrm wrote:

You should be able to commit to src. Have you tried? If so, it's probably a git hook that's preventing you. Can you show the output?

One other thing that's not a blocker here. Your diffs don't have any context for some reason. Are you using arc diff --create... or git arc... (if you use freebsd-git-devtools from devel/freebsd-git-devtools)? If so, I'll ask someone from phabric-admin@ why there is no context.

Hold on old for a second, let my try to commit. I didn't try. Also created the patch with git format-patch, about to install phabricator tools.

It did work:

osipovmi@deblndw011x:~/var/Projekte/freebsd/src (main >)
$ git push
Objekte aufzählen: 9, fertig.
Zähle Objekte: 100% (9/9), fertig.
Delta-Kompression verwendet bis zu 20 Threads.
Komprimiere Objekte: 100% (5/5), fertig.
Schreibe Objekte: 100% (5/5), 635 Bytes | 317.00 KiB/s, fertig.
Gesamt 5 (Delta 4), Wiederverwendet 0 (Delta 0), Pack wiederverwendet 0
To gitrepo.freebsd.org:src.git
   9eff6390718d..7e5504d3d8ca  main -> main

Closing since this has been pushed to main.

It will close automatically with a line like Differential Revision: https://reviews.freebsd.org/D42293, but I just now notice it had Differential Review:.... No biggie, but you'll want to get the commit template set up to make your life (and ours) easier. :)

https://cgit.freebsd.org/ports/commit/?id=5e7bdbf4c15ac7cccd7d6352db03efc7f7412336

In D42293#965038, @jrm wrote:

It will close automatically with a line like Differential Revision: https://reviews.freebsd.org/D42293, but I just now notice it had Differential Review:.... No biggie, but you'll want to get the commit template set up to make your life (and ours) easier. :)

https://cgit.freebsd.org/ports/commit/?id=5e7bdbf4c15ac7cccd7d6352db03efc7f7412336

Indeed, my bad. Next open one is correct, though.