Add prototype for random_harvest_queue
ClosedPublic
Actions

Authored by stevek on Nov 20 2015, 6:39 AM.

Details

Reviewers

sjg
jmg
markm

Summary

Add a prototype for random_harvest_queue to dev/random/random_harvestq.h
This fixes a warning that occurs in a number of files that use the random_harvest_queue function.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

stevek updated this revision to Diff 10369.Nov 20 2015, 6:39 AM

stevek retitled this revision from to Add prototype for random_harvest_queue.

stevek updated this object.

stevek edited the test plan for this revision. (Show Details)

stevek added a reviewer: markm.

stevek set the repository for this revision to rS FreeBSD src repository - subversion.

Herald added a reviewer: jmg. · View Herald TranscriptNov 20 2015, 6:39 AM

Herald added a subscriber: imp. · View Herald Transcript

sjg added a subscriber: sjg.Dec 7 2015, 11:20 PM

sjg added inline comments.

sys/dev/random/random_harvestq.h
46–48	I would omit the variable names.

Updated with suggested comments.

Herald edited edge metadata. · View Herald TranscriptJun 8 2016, 4:01 PM

LGTM

This revision is now accepted and ready to land.Jun 8 2016, 5:13 PM

Looks OK to me.

Looks like the prototype exists in random.h already. I'll need to go back and find out what was complaining in the compiler that needed the change. Probably a missing include for sys/random.h or something like that.

Revision Contents
Changeset List

Path

Size

sys/

dev/

random/

random_harvestq.h

4 lines

Diff 17423

View Options

sys/dev/random/random_harvestq.h

Add prototype for random_harvest_queueClosedPublicActions