Differential D42238

bsdinstall partedit: Replace malloc + sprintf with asprintf
ClosedPublic
Actions

Authored by jhb on Oct 16 2023, 10:12 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Sep 6, 4:15 AM

	Unknown Object (File)
	Sat, Sep 5, 7:29 PM

	Unknown Object (File)
	Sat, Sep 5, 6:25 PM

	Unknown Object (File)
	Sat, Sep 5, 6:08 PM

	Unknown Object (File)
	Sat, Sep 5, 6:08 PM

	Unknown Object (File)
	Sat, Sep 5, 1:10 PM

	Unknown Object (File)
	Sat, Sep 5, 1:07 PM

	Unknown Object (File)
	Sat, Sep 5, 10:19 AM

Subscribers

Details

Reviewers

Commits

rG653e8fb20e84: bsdinstall partedit: Replace malloc + sprintf with asprintf
rGbb049096be78: bsdinstall partedit: Replace malloc + sprintf with asprintf
rG51749e05e96e: bsdinstall partedit: Replace malloc + sprintf with asprintf

Summary

This avoids potential bugs with the length passed to malloc not
matching the string written via sprintf.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Oct 16 2023, 10:12 PM

Herald added subscribers: jrtc27, imp. · View Herald TranscriptOct 16 2023, 10:12 PM

jhb requested review of this revision.Oct 16 2023, 10:12 PM

jhb added a parent revision: D42237: bsdinstall partedit: Avoid potential buffer overflow in newfs_command.

jhb added a child revision: D42239: bsdinstall partedit: Use asprintf to build wrapper command for newfs.

Harbormaster completed remote builds in B54015: Diff 128857.Oct 16 2023, 10:12 PM

emaste accepted this revision.Oct 16 2023, 10:14 PM

This revision is now accepted and ready to land.Oct 16 2023, 10:14 PM

Closed by commit rG51749e05e96e: bsdinstall partedit: Replace malloc + sprintf with asprintf (authored by jhb). · Explain WhyOct 16 2023, 11:32 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG51749e05e96e: bsdinstall partedit: Replace malloc + sprintf with asprintf.

jhb added a commit: rGbb049096be78: bsdinstall partedit: Replace malloc + sprintf with asprintf.Jan 2 2024, 8:53 PM

jhb added a commit: rG653e8fb20e84: bsdinstall partedit: Replace malloc + sprintf with asprintf.Jan 5 2024, 12:25 AM

Revision Contents
Changeset List

Path

Size

usr.sbin/

bsdinstall/

partedit/

10 lines

4 lines

Diff 128879

usr.sbin/bsdinstall/partedit/gpart_ops.c

Loading...

usr.sbin/bsdinstall/partedit/partedit.c

Loading...