Differential D42159

ping: Consistently use EX_NOHOST for DNS failures.
ClosedPublic
Actions

Authored by des on Oct 11 2023, 7:18 PM.

Tags

None

Referenced Files

	F83939542: D42159.id128610.diff
	Fri, May 17, 2:57 AM

	Unknown Object (File)
	Thu, May 2, 7:10 AM

	Unknown Object (File)
	Sat, Apr 20, 5:14 PM

	Unknown Object (File)
	Apr 14 2024, 6:54 PM

	Unknown Object (File)
	Apr 14 2024, 5:50 PM

	Unknown Object (File)
	Apr 6 2024, 8:07 PM

	Unknown Object (File)
	Mar 19 2024, 3:26 PM

	Unknown Object (File)
	Mar 19 2024, 3:20 PM

View All 14 Files

Subscribers

Details

Reviewers

rscheff
siderop1_netapp.com
kevans

Group Reviewers

Commits

rGc4ffb80ef18f: ping: Consistently use EX_NOHOST for DNS failures.

Summary

Traditionally, ping returned exit code EX_NOHOST if a DNS lookup failed.
That is still the case for the legacy code in the new merged ping, but
not for IPv6 targets, nor when a DNS lookup is performed in order to
determine which version of the tool to invoke.

While here, also make sure that the error message is consistent.

Sponsored by: NetApp, Inc.
Sponsored by: Klara, Inc.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

des created this revision.Oct 11 2023, 7:18 PM

Herald added a subscriber: imp. · View Herald TranscriptOct 11 2023, 7:18 PM

des requested review of this revision.Oct 11 2023, 7:18 PM

Harbormaster completed remote builds in B53927: Diff 128604.Oct 11 2023, 7:18 PM

siderop1_netapp.com accepted this revision.Oct 11 2023, 7:21 PM

This revision is now accepted and ready to land.Oct 11 2023, 7:21 PM

kevans accepted this revision.Oct 11 2023, 7:32 PM

add test cases

This revision now requires review to proceed.Oct 11 2023, 7:38 PM

Harbormaster completed remote builds in B53929: Diff 128608.Oct 11 2023, 7:38 PM

kevans accepted this revision.Oct 11 2023, 7:41 PM

This revision is now accepted and ready to land.Oct 11 2023, 7:41 PM

Closed by commit rGc4ffb80ef18f: ping: Consistently use EX_NOHOST for DNS failures. (authored by des). · Explain WhyOct 11 2023, 7:46 PM

This revision was automatically updated to reflect the committed changes.

des added a commit: rGc4ffb80ef18f: ping: Consistently use EX_NOHOST for DNS failures..

des mentioned this in rG0648be66c477: ping: Simplify protocol selection..Dec 13 2023, 8:09 PM

des mentioned this in rG8b55607a7fa3: ping: Simplify protocol selection..

Revision Contents
Changeset List

Path

Size

sbin/

ping/

10 lines

5 lines

tests/

36 lines

Diff 128610

sbin/ping/main.c

Loading...

sbin/ping/ping6.c

Loading...

sbin/ping/tests/ping_test.sh

Loading...