Page MenuHomeFreeBSD
Differential D42159

ping: Consistently use EX_NOHOST for DNS failures.
ClosedPublic
Actions

Authored by des on Oct 11 2023, 7:18 PM.
Tags
None
Referenced Files
F157401457: D42159.diff
Thu, May 21, 12:29 AM
Unknown Object (File)
Wed, May 20, 3:18 AM
Unknown Object (File)
Tue, May 19, 11:52 PM
Unknown Object (File)
Tue, May 19, 2:10 PM
Unknown Object (File)
Tue, May 19, 5:16 AM
Unknown Object (File)
Mon, May 18, 10:39 PM
Unknown Object (File)
Sat, May 16, 10:55 PM
Unknown Object (File)
Fri, May 15, 2:40 PM
View All Files
Subscribers
imp

Details

Reviewers
rscheff
siderop1_netapp.com
kevans
Group Reviewers
Klara
Commits
rGc4ffb80ef18f: ping: Consistently use EX_NOHOST for DNS failures.
Summary

Traditionally, ping returned exit code EX_NOHOST if a DNS lookup failed.
That is still the case for the legacy code in the new merged ping, but
not for IPv6 targets, nor when a DNS lookup is performed in order to
determine which version of the tool to invoke.

While here, also make sure that the error message is consistent.

Sponsored by: NetApp, Inc.
Sponsored by: Klara, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

des created this revision.Oct 11 2023, 7:18 PM
Herald added a subscriber: imp. · View Herald TranscriptOct 11 2023, 7:18 PM
des requested review of this revision.Oct 11 2023, 7:18 PM
Harbormaster completed remote builds in B53927: Diff 128604.Oct 11 2023, 7:18 PM
siderop1_netapp.com accepted this revision.Oct 11 2023, 7:21 PM
This revision is now accepted and ready to land.Oct 11 2023, 7:21 PM
kevans accepted this revision.Oct 11 2023, 7:32 PM
des updated this revision to Diff 128608.Oct 11 2023, 7:38 PM

add test cases

This revision now requires review to proceed.Oct 11 2023, 7:38 PM
Harbormaster completed remote builds in B53929: Diff 128608.Oct 11 2023, 7:38 PM
kevans accepted this revision.Oct 11 2023, 7:41 PM
This revision is now accepted and ready to land.Oct 11 2023, 7:41 PM
Closed by commit rGc4ffb80ef18f: ping: Consistently use EX_NOHOST for DNS failures. (authored by des). · Explain WhyOct 11 2023, 7:46 PM
This revision was automatically updated to reflect the committed changes.
des added a commit: rGc4ffb80ef18f: ping: Consistently use EX_NOHOST for DNS failures..
des mentioned this in rG0648be66c477: ping: Simplify protocol selection..Dec 13 2023, 8:09 PM
des mentioned this in rG8b55607a7fa3: ping: Simplify protocol selection..

Revision Contents
Changeset List

PathSize
sbin/
ping/
10 lines
5 lines
tests/
36 lines

Diff 128610

View Options

sbin/ping/main.c

Loading...
View Options

sbin/ping/ping6.c

Loading...
View Options

sbin/ping/tests/ping_test.sh

Loading...