Page MenuHomeFreeBSD
Differential D42073

Remove unneeded CA_BUNDLE option.
Needs RevisionPublic
Actions

Authored by des on Oct 4 2023, 12:55 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 15, 6:30 AM
Unknown Object (File)
Nov 30 2024, 12:59 PM
Unknown Object (File)
Nov 16 2024, 2:06 AM
Unknown Object (File)
Nov 6 2024, 2:23 PM
Unknown Object (File)
Oct 17 2024, 9:01 AM
Unknown Object (File)
Oct 17 2024, 9:01 AM
Unknown Object (File)
Oct 17 2024, 9:01 AM
Unknown Object (File)
Oct 17 2024, 9:00 AM
View All Files
Subscribers
fullermd_over-yonder.net
mat

Details

Reviewers
ehaupt
pizzamig
fullermd_over-yonder.net
Group Reviewers
portmgr
Commits
R11:38f33709d711: irc/hexchat: Remove unneeded CA_BUNDLE option.
R11:0bbc60316aa1: dns/libasr-devel: Remove unneeded CA_BUNDLE option.
R11:bde578cbfcf9: mail/opensmtpd: Remove unneeded CA_BUNDLE option.
R11:175afd75038b: devel/mercurial: Remove unneeded CA_BUNDLE option.
R11:6e968aff79f9: mail/fetchmail: Remove unneeded CA_BUNDLE option.
R11:261441b93439: irc/weechat: Update to 4.0.5
Summary

MFH: 2023Q4

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

des created this revision.Oct 4 2023, 12:55 PM
Herald added a subscriber: mat. · View Herald TranscriptOct 4 2023, 12:55 PM
des requested review of this revision.Oct 4 2023, 12:55 PM
Harbormaster completed remote builds in B53829: Diff 128217.Oct 4 2023, 12:55 PM
fluffy added a comment.Oct 4 2023, 1:59 PM

lgtm

This revision was not accepted when it landed; it landed in state Needs Review.Oct 4 2023, 7:35 PM
Closed by commit R11:261441b93439: irc/weechat: Update to 4.0.5 (authored by brnrd). · Explain Why
This revision was automatically updated to reflect the committed changes.
brnrd added a commit: R11:261441b93439: irc/weechat: Update to 4.0.5.
brnrd reopened this revision.EditedOct 4 2023, 7:37 PM

irc/weechat had a pending update. Incorporated the CA_BUNDLE change.

Hope that doesn't disrupt your workflow too much... WHY does it delete all the other changes :'(

des added a comment.Oct 5 2023, 12:12 AM
In D42073#959825, @brnrd wrote:

WHY does it delete all the other changes :'(

Because you told Phabricator that your commit was the final version of this differential.

des updated this revision to Diff 128269.Oct 5 2023, 12:34 AM

rebase

Harbormaster completed remote builds in B53841: Diff 128269.Oct 5 2023, 12:34 AM
sunpoet accepted this revision.Oct 5 2023, 5:21 PM
sunpoet added a subscriber: sunpoet.

LGTM for devel/mercurial. Thanks.

This revision is now accepted and ready to land.Oct 5 2023, 5:21 PM
brnrd added a comment.Oct 6 2023, 6:56 AM
In D42073#959887, @des wrote:
In D42073#959825, @brnrd wrote:

WHY does it delete all the other changes :'(

Because you told Phabricator that your commit was the final version of this differential.

All I did is refer to this review in the commit message. Learned something new!

Closed by commit R11:175afd75038b: devel/mercurial: Remove unneeded CA_BUNDLE option. (authored by des). · Explain WhyOct 6 2023, 9:07 AM
This revision was automatically updated to reflect the committed changes.
des added a commit: R11:175afd75038b: devel/mercurial: Remove unneeded CA_BUNDLE option..
des added a commit: R11:6e968aff79f9: mail/fetchmail: Remove unneeded CA_BUNDLE option..
des reopened this revision.Oct 6 2023, 9:10 AM
des removed a reviewer: Python.
des removed a subscriber: sunpoet.
des updated this revision to Diff 128339.Oct 6 2023, 9:10 AM

rebase

Harbormaster completed remote builds in B53864: Diff 128339.Oct 6 2023, 9:10 AM
des removed reviewers: brnrd, sunpoet.Oct 6 2023, 9:12 AM
This revision was not accepted when it landed; it landed in state Needs Review.Oct 6 2023, 9:47 AM
Closed by commit R11:bde578cbfcf9: mail/opensmtpd: Remove unneeded CA_BUNDLE option. (authored by des). · Explain Why
This revision was automatically updated to reflect the committed changes.
des added a commit: R11:bde578cbfcf9: mail/opensmtpd: Remove unneeded CA_BUNDLE option..
des added a commit: R11:0bbc60316aa1: dns/libasr-devel: Remove unneeded CA_BUNDLE option..
des reopened this revision.Oct 6 2023, 9:50 AM
des removed a reviewer: fluffy.
des updated this revision to Diff 128345.Oct 6 2023, 9:50 AM

rebase

Harbormaster completed remote builds in B53867: Diff 128345.Oct 6 2023, 9:51 AM
pkubaj accepted this revision.Oct 6 2023, 4:18 PM
This revision is now accepted and ready to land.Oct 6 2023, 4:18 PM
Closed by commit R11:38f33709d711: irc/hexchat: Remove unneeded CA_BUNDLE option. (authored by des). · Explain WhyOct 8 2023, 4:45 AM
This revision was automatically updated to reflect the committed changes.
des added a commit: R11:38f33709d711: irc/hexchat: Remove unneeded CA_BUNDLE option..
des reopened this revision.Oct 8 2023, 4:45 AM
des removed a reviewer: pkubaj.
des updated this revision to Diff 128415.Oct 8 2023, 4:47 AM

rebase

Harbormaster completed remote builds in B53891: Diff 128415.Oct 8 2023, 4:47 AM
fullermd_over-yonder.net requested changes to this revision.Oct 9 2023, 4:00 PM
fullermd_over-yonder.net added a subscriber: fullermd_over-yonder.net.

NACK for devel/brz. It really wants a single bundle file to point to. I did a little experimentation, and didn't come up with a simple clean patch to work around it, so it'll take a bit more work and upstream engagement to gently beat it into shape.

(I'm assuming the goal here is "let's wind down unnecessary uses of this", not "stop using this everywhere immediately!!1!", so this is a "plan to", not "drop everything to")

This revision now requires changes to proceed.Oct 9 2023, 4:00 PM
des added a comment.Oct 9 2023, 8:02 PM

I think we're going to end up having to have certctl(8) produce a bundle in addition to the hashed directory.

Revision Contents
Changeset List

PathSize
irc/
hexchat/
9 lines

Diff 128414

View Options

irc/hexchat/Makefile

Loading...