Page MenuHomeFreeBSD

Remove unneeded CA_BUNDLE option.
Needs RevisionPublic

Authored by des on Oct 4 2023, 12:55 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jun 9, 5:18 AM
Unknown Object (File)
Tue, Jun 4, 2:27 PM
Unknown Object (File)
Tue, Jun 4, 10:29 AM
Unknown Object (File)
Mon, Jun 3, 4:28 AM
Unknown Object (File)
Sun, Jun 2, 5:30 AM
Unknown Object (File)
Sat, Jun 1, 5:17 AM
Unknown Object (File)
Thu, May 23, 10:07 AM
Unknown Object (File)
Wed, May 22, 12:05 PM

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 53891
Build 50782: arc lint + arc unit

Event Timeline

des requested review of this revision.Oct 4 2023, 12:55 PM
This revision was not accepted when it landed; it landed in state Needs Review.Oct 4 2023, 7:35 PM
This revision was automatically updated to reflect the committed changes.
brnrd reopened this revision.EditedOct 4 2023, 7:37 PM

irc/weechat had a pending update. Incorporated the CA_BUNDLE change.

Hope that doesn't disrupt your workflow too much... WHY does it delete all the other changes :'(

WHY does it delete all the other changes :'(

Because you told Phabricator that your commit was the final version of this differential.

sunpoet added a subscriber: sunpoet.

LGTM for devel/mercurial. Thanks.

This revision is now accepted and ready to land.Oct 5 2023, 5:21 PM
In D42073#959887, @des wrote:

WHY does it delete all the other changes :'(

Because you told Phabricator that your commit was the final version of this differential.

All I did is refer to this review in the commit message. Learned something new!

des removed a reviewer: Python.
des removed a subscriber: sunpoet.
This revision was not accepted when it landed; it landed in state Needs Review.Oct 6 2023, 9:47 AM
This revision was automatically updated to reflect the committed changes.
des removed a reviewer: fluffy.
This revision is now accepted and ready to land.Oct 6 2023, 4:18 PM
This revision was automatically updated to reflect the committed changes.
des removed a reviewer: pkubaj.

NACK for devel/brz. It really wants a single bundle file to point to. I did a little experimentation, and didn't come up with a simple clean patch to work around it, so it'll take a bit more work and upstream engagement to gently beat it into shape.

(I'm assuming the goal here is "let's wind down unnecessary uses of this", not "stop using this everywhere immediately!!1!", so this is a "plan to", not "drop everything to")

This revision now requires changes to proceed.Oct 9 2023, 4:00 PM

I think we're going to end up having to have certctl(8) produce a bundle in addition to the hashed directory.