Paths

Table of Contentst

Differential D42011

split: Improve GNU compatibility.
ClosedPublic
Actions

Authored by des on Sep 28 2023, 1:18 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Oct 14, 9:51 AM

	Unknown Object (File)
	Tue, Oct 14, 9:51 AM

	Unknown Object (File)
	Tue, Oct 14, 9:51 AM

	Unknown Object (File)
	Tue, Oct 14, 9:51 AM

	Unknown Object (File)
	Mon, Oct 13, 7:48 PM

	Unknown Object (File)
	Mon, Oct 13, 9:24 AM

	Unknown Object (File)
	Thu, Oct 9, 9:05 PM

	Unknown Object (File)
	Wed, Sep 24, 8:26 PM

Subscribers

Details

Reviewers

christos
kevans

Group Reviewers

Commits

rGd9d69a6f6fc1: split: Improve GNU compatibility.

Summary

Like GNU split, turn autoextend back on if given -a0.
Add a test case that verifies that -a<non-zero> turns autoextend off.
Add a test case that verifies that -a0 turns autoextend back on.

Sponsored by: Klara, Inc.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

des created this revision.Sep 28 2023, 1:18 PM

Herald added a subscriber: imp. · View Herald TranscriptSep 28 2023, 1:18 PM

des requested review of this revision.Sep 28 2023, 1:18 PM

des added a parent revision: D42010: split: Further option parsing improvements..

Harbormaster completed remote builds in B53755: Diff 127901.Sep 28 2023, 1:18 PM

christos accepted this revision.Sep 28 2023, 1:29 PM

christos added inline comments.

usr.bin/split/tests/split_test.sh
216	Shouldn't that be -a0?

This revision is now accepted and ready to land.Sep 28 2023, 1:29 PM

des marked an inline comment as done.Sep 28 2023, 1:38 PM

des added inline comments.

usr.bin/split/tests/split_test.sh
216	No, `-a0` would turn autoextend _on_ which is the opposite of what we want here. Though I suppose I could add a test case for turning it off and then on again (`-a2 -a0`).

christos added inline comments.Sep 28 2023, 1:49 PM

usr.bin/split/tests/split_test.sh
216	Yeap, it'd be good to have a test to test this functionality.

des marked 2 inline comments as done.Sep 28 2023, 3:53 PM

one more test case

This revision now requires review to proceed.Sep 28 2023, 3:54 PM

Harbormaster completed remote builds in B53757: Diff 127953.Sep 28 2023, 3:54 PM

des edited the summary of this revision. (Show Details)Sep 28 2023, 3:55 PM

christos accepted this revision.Sep 28 2023, 4:01 PM

This revision is now accepted and ready to land.Sep 28 2023, 4:01 PM

kevans accepted this revision.Sep 28 2023, 4:20 PM

Closed by commit rGd9d69a6f6fc1: split: Improve GNU compatibility. (authored by des). · Explain WhySep 28 2023, 4:39 PM

This revision was automatically updated to reflect the committed changes.

des added a commit: rGd9d69a6f6fc1: split: Improve GNU compatibility..

des mentioned this in rGb3cef2d2f538: split: Further option parsing improvements..Oct 5 2023, 12:02 AM

des mentioned this in rGdb95aeb922c9: split: Further option parsing improvements..Oct 5 2023, 3:56 PM

Revision Contents
Changeset List

Path

Size

usr.bin/

split/

7 lines

tests/

19 lines

Diff 127965

usr.bin/split/split.c

Loading...

usr.bin/split/tests/split_test.sh

Loading...