Page MenuHomeFreeBSD

split: Improve GNU compatibility.
ClosedPublic

Authored by des on Sep 28 2023, 1:18 PM.
Tags
None
Referenced Files
Unknown Object (File)
May 6 2024, 3:53 PM
Unknown Object (File)
Apr 30 2024, 4:08 PM
Unknown Object (File)
Apr 30 2024, 4:08 PM
Unknown Object (File)
Apr 30 2024, 4:08 PM
Unknown Object (File)
Apr 30 2024, 4:08 PM
Unknown Object (File)
Apr 30 2024, 9:08 AM
Unknown Object (File)
Mar 7 2024, 3:10 PM
Unknown Object (File)
Jan 16 2024, 3:32 PM
Subscribers

Details

Summary
  • Like GNU split, turn autoextend back on if given -a0.
  • Add a test case that verifies that -a<non-zero> turns autoextend off.
  • Add a test case that verifies that -a0 turns autoextend back on.

Sponsored by: Klara, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

christos added inline comments.
usr.bin/split/tests/split_test.sh
216

Shouldn't that be -a0?

This revision is now accepted and ready to land.Sep 28 2023, 1:29 PM
des marked an inline comment as done.Sep 28 2023, 1:38 PM
des added inline comments.
usr.bin/split/tests/split_test.sh
216

No, -a0 would turn autoextend _on_ which is the opposite of what we want here. Though I suppose I could add a test case for turning it off and then on again (-a2 -a0).

usr.bin/split/tests/split_test.sh
216

Yeap, it'd be good to have a test to test this functionality.

des marked 2 inline comments as done.Sep 28 2023, 3:53 PM
This revision now requires review to proceed.Sep 28 2023, 3:54 PM
This revision is now accepted and ready to land.Sep 28 2023, 4:01 PM
This revision was automatically updated to reflect the committed changes.