Page MenuHomeFreeBSD

Add USES=7z support
ClosedPublic

Authored by jbeich on Nov 17 2015, 8:01 AM.
Tags
None
Referenced Files
F104000366: D4190.diff
Mon, Dec 2, 5:54 AM
Unknown Object (File)
Sat, Nov 30, 4:21 PM
Unknown Object (File)
Mon, Nov 25, 6:41 PM
Unknown Object (File)
Mon, Nov 25, 6:32 AM
Unknown Object (File)
Sat, Nov 23, 9:25 PM
Unknown Object (File)
Sat, Nov 23, 9:19 AM
Unknown Object (File)
Fri, Nov 22, 5:59 PM
Unknown Object (File)
Fri, Nov 22, 4:02 PM
Subscribers

Details

Summary

Common way to extract .7z files. Can take advantage of libarchive support. Maybe not very useful due to low number of consumers. See examples for usage.

Initial version is based on devel/fb-adb, so expect rough edges.

Test Plan

Build examples on 9.x and 10.x.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 1184
Build 1188: arc lint + arc unit

Event Timeline

jbeich retitled this revision from to Add USES=7z support.
jbeich updated this object.
jbeich edited the test plan for this revision. (Show Details)
jbeich added a reviewer: portmgr.
jbeich edited edge metadata.

devel/fb-adb: OVERRIDE_LINUX_BASE_PORT check can be easily killed now.

jbeich edited edge metadata.

Oops, fix USES=7z:partial regression: DISTFILES vs. _DISTFILES.

All targets should be done in a POST section

I have seen that other USES are not pushing target in a post section they must be fixed

otherwise looks good to me

In D4190#103040, @bapt wrote:

All targets should be done in a POST section

Rationale? "Traditionally" isn't a valid one as rP394503 was designed to break it. For USES=7z the current order not only safeguards do-p7zip-extract from quirks in individual ports but also allows post-extract to fix up paths/etc after extraction of *.7z files, similar to *.tar.gz.

@bapt, if by "post" section you mean the fact that the target is called do-* then it's irrelevant, it's run after the do-extract target, so it feels kinda ok to me.

bapt added a reviewer: bapt.

yes you are right, my bad

This revision is now accepted and ready to land.Mar 23 2016, 9:58 PM
This revision was automatically updated to reflect the committed changes.