Add USES=7z support
ClosedPublic
Actions

Authored by jbeich on Nov 17 2015, 8:01 AM.

Details

Reviewers

bapt

Group Reviewers

portmgr

Commits

rP411858: Convert to USES=7z for trivial cases
rP411857: devel/fb-adb: convert to USES=7z:partial
rP411856: Add USES=7z support: common way to extract 7-Zip archives

Summary

Common way to extract .7z files. Can take advantage of libarchive support. Maybe not very useful due to low number of consumers. See examples for usage.

Initial version is based on devel/fb-adb, so expect rough edges.

Test Plan

Build examples on 9.x and 10.x.

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jbeich updated this revision to Diff 10256.Nov 17 2015, 8:01 AM

jbeich retitled this revision from to Add USES=7z support.

jbeich updated this object.

jbeich edited the test plan for this revision. (Show Details)

jbeich added a reviewer: portmgr.

Herald edited edge metadata. · View Herald TranscriptNov 17 2015, 8:01 AM

devel/fb-adb: OVERRIDE_LINUX_BASE_PORT check can be easily killed now.

Herald edited edge metadata. · View Herald TranscriptNov 17 2015, 8:20 AM

Oops, fix USES=7z:partial regression: DISTFILES vs. _DISTFILES.

Herald edited edge metadata. · View Herald TranscriptNov 17 2015, 8:47 AM

All targets should be done in a POST section

I have seen that other USES are not pushing target in a post section they must be fixed

otherwise looks good to me

In D4190#103040, @bapt wrote:

All targets should be done in a POST section

Rationale? "Traditionally" isn't a valid one as rP394503 was designed to break it. For USES=7z the current order not only safeguards do-p7zip-extract from quirks in individual ports but also allows post-extract to fix up paths/etc after extraction of *.7z files, similar to *.tar.gz.

@bapt, if by "post" section you mean the fact that the target is called do-* then it's irrelevant, it's run after the do-extract target, so it feels kinda ok to me.