x11/plasma5-plasma-desktop: add option PIPEWIRE to allow build without pipewire

[vvd]

Summary

Add option PIPEWIRE to allow build without pipewire.
Default ON - same as was before.

Tested on 13.2 amd64 in poudriere and live system.

P.S. Without patches it build and work fine if pipewire is not installed in system.

[tcberner]

Not a fan of carrying a patch for this.

ecm_find_qmlmlodule seems to call find_package, so you might be able to use CMAKE_DISABLE_FIND_PACKAGE_xyz

[vvd]

In D41864#954190, @tcberner wrote:

Not a fan of carrying a patch for this.

Patch x11/plasma5-plasma-desktop/files/patch-CMakeLists.txt for prevent silent grab of the kpipewire if kpipewire is installed and user turn off the option PIPEWIRE.
And for fail configure stage if kpipewire isn't installed, but user turn on the option PIPEWIRE.

[vvd]

In D41864#954190, @tcberner wrote:

ecm_find_qmlmlodule seems to call find_package, so you might be able to use CMAKE_DISABLE_FIND_PACKAGE_xyz

What is "xyz" in this case?
Not PIPEWIRE, not KPIPEWIRE.

[arrowd]

In D41864#954296, @vvd wrote:

In D41864#954190, @tcberner wrote:

ecm_find_qmlmlodule seems to call find_package, so you might be able to use CMAKE_DISABLE_FIND_PACKAGE_xyz

What is "xyz" in this case?
Not PIPEWIRE, not KPIPEWIRE.

xyz stands for what is passed into find_package: https://cmake.org/cmake/help/latest/variable/CMAKE_DISABLE_FIND_PACKAGE_PackageName.html

[vvd]

In D41864#954301, @arrowd wrote:

In D41864#954296, @vvd wrote:

In D41864#954190, @tcberner wrote:

ecm_find_qmlmlodule seems to call find_package, so you might be able to use CMAKE_DISABLE_FIND_PACKAGE_xyz

What is "xyz" in this case?
Not PIPEWIRE, not KPIPEWIRE.

xyz stands for what is passed into find_package: https://cmake.org/cmake/help/latest/variable/CMAKE_DISABLE_FIND_PACKAGE_PackageName.html

How to determine this if ecm_find_qmlmodule is called and not find_package directly?

[vvd]

How to determine this if ecm_find_qmlmodule is called and not find_package directly?

CMAKE_DISABLE_FIND_PACKAGE_org.kde.pipewire-QMLModule

[arrowd]

In D41864#954311, @vvd wrote:

How to determine this if ecm_find_qmlmodule is called and not find_package directly?

Just a bit of searching: https://github.com/KDE/extra-cmake-modules/blob/ed9b7b7eb95bb66e92f2eff39ad8cf3b36cb1b76/modules/ECMFindQmlModule.cmake#L52

[vvd]

In D41864#954323, @arrowd wrote:

In D41864#954311, @vvd wrote:

How to determine this if ecm_find_qmlmodule is called and not find_package directly?

Just a bit of searching: https://github.com/KDE/extra-cmake-modules/blob/ed9b7b7eb95bb66e92f2eff39ad8cf3b36cb1b76/modules/ECMFindQmlModule.cmake#L52

Already found in /usr/local/share/ECM/modules/ECMFindQmlModule.cmake:

function(ecm_find_qmlmodule MODULE_NAME VERSION)
    set(GENMODULE "${MODULE_NAME}-QMLModule")
…
find_package(${GENMODULE} ${ARGN})

[arrowd]

Looks good, although I didn't run-test it. But it should be fine, right?

[vvd]

In D41864#955078, @arrowd wrote:

Looks good, although I didn't run-test it. But it should be fine, right?

Yes, I'm using it with PIPEWIRE OFF. With ON it's same as without this patch.