Page MenuHomeFreeBSD

sdhci: fdt: Correctly export clock per the binding
ClosedPublic

Authored by manu on Sep 11 2023, 11:48 AM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 1 2024, 12:27 PM
Unknown Object (File)
Jan 3 2024, 12:23 PM
Unknown Object (File)
Dec 20 2023, 6:36 AM
Unknown Object (File)
Dec 17 2023, 3:09 AM
Unknown Object (File)
Nov 18 2023, 9:37 PM
Unknown Object (File)
Oct 17 2023, 6:11 PM
Unknown Object (File)
Oct 11 2023, 12:47 PM
Unknown Object (File)
Oct 11 2023, 12:47 PM
Subscribers

Details

Summary

The binding says that we can have one or two clocks to export.
The first one is the actual sdclock while the second is the sample clock.
Both have the same parent, clk_xin.
Correctly export the clocks for RK3399 and ZynqMP.
No need to use a high ID as before, we have our own clock domain so use
ids starting at 1 as all exported clocks should be.

Sponsored by: Beckhoff Automation GmbH & Co. KG

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

manu requested review of this revision.Sep 11 2023, 11:48 AM

Scrolling through looks ok to me.

sys/dev/sdhci/sdhci_fdt.c
357

Hmm should this be part of D41809?

sys/dev/sdhci/sdhci_fdt.c
357

No, this is the old function name that exported the clock

bz added inline comments.
sys/dev/sdhci/sdhci_fdt.c
357

Sorry, I went by email order and that was confusing.

This revision is now accepted and ready to land.Sep 11 2023, 1:07 PM