makeman: Use ${make} instead of plain make to compute ${requireds}
ClosedPublic
Actions

Authored by jhb on Sep 8 2023, 1:39 AM.

Details

Reviewers

jrtc27
emaste
imp

Commits

rGe949b671c555: makeman: Use ${make} instead of plain make to compute ${requireds}
rG9c80d66ec1b4: makeman: Use ${make} instead of plain make to compute ${requireds}

Summary

This is currently a no-op but can matter for downstreams whose ${make}
includes additional settings.

Obtained from: CheriBSD
Sponsored by: DARPA

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Sep 8 2023, 1:39 AM

Herald added a subscriber: imp. · View Herald TranscriptSep 8 2023, 1:39 AM

jhb requested review of this revision.Sep 8 2023, 1:39 AM

Harbormaster completed remote builds in B53496: Diff 127097.Sep 8 2023, 1:39 AM

jhb added a reviewer: emaste.Sep 8 2023, 1:40 AM

Seems fine

This revision is now accepted and ready to land.Sep 8 2023, 1:56 AM

imp accepted this revision.Sep 8 2023, 4:53 AM

imp added inline comments.

tools/build/options/makeman
132	So it already was ${make} here.. Amy place else need it while you are here?

jhb marked an inline comment as done.Sep 8 2023, 6:56 PM

jhb added inline comments.

tools/build/options/makeman
132	The rest of the places all use ${make} already.

Closed by commit rG9c80d66ec1b4: makeman: Use ${make} instead of plain make to compute ${requireds} (authored by jhb). · Explain WhySep 8 2023, 11:38 PM

This revision was automatically updated to reflect the committed changes.

jhb marked an inline comment as done.

jhb added a commit: rG9c80d66ec1b4: makeman: Use ${make} instead of plain make to compute ${requireds}.

jhb added a commit: rGe949b671c555: makeman: Use ${make} instead of plain make to compute ${requireds}.Oct 24 2023, 6:40 PM

Revision Contents
Changeset List

Path

Size

tools/

build/

options/

makeman

2 lines

Diff 127156

View Options

tools/build/options/makeman

makeman: Use ${make} instead of plain make to compute ${requireds}ClosedPublicActions