Page MenuHomeFreeBSD
Differential D41772

pf: fix state leak
ClosedPublic
Actions

Authored by kp on Sep 7 2023, 3:39 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Dec 24, 8:02 PM
Unknown Object (File)
Tue, Dec 23, 10:12 AM
Unknown Object (File)
Nov 22 2025, 2:31 PM
Unknown Object (File)
Nov 12 2025, 3:16 PM
Unknown Object (File)
Nov 10 2025, 2:16 AM
Unknown Object (File)
Nov 8 2025, 8:42 PM
Unknown Object (File)
Nov 3 2025, 8:56 PM
Unknown Object (File)
Nov 3 2025, 8:56 PM
View All 91 Files
Subscribers
farrokhi
glebius
imp
melifaro

Details

Reviewers
None
Group Reviewers
pfsense
network
Commits
rGddca690373e5: pf: fix state leak
rGed82385135cc: pf: fix state leak
rGb6ce41118bb1: pf: fix state leak
Summary

If we hit the csfailed case in pf_create_state() we may have allocated
a state, so we must also free it. While here reduce the amount of
duplicated cleanup code.

MFC after: 1 week
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kp created this revision.Sep 7 2023, 3:39 PM
Herald added subscribers: glebius, melifaro, farrokhi, imp. · View Herald TranscriptSep 7 2023, 3:39 PM
kp requested review of this revision.Sep 7 2023, 3:39 PM
Harbormaster completed remote builds in B53493: Diff 127065.Sep 7 2023, 3:39 PM
This revision was not accepted when it landed; it landed in state Needs Review.Sep 10 2023, 8:40 PM
Closed by commit rGb6ce41118bb1: pf: fix state leak (authored by kp). · Explain Why
This revision was automatically updated to reflect the committed changes.
kp added a commit: rGb6ce41118bb1: pf: fix state leak.
kp added a commit: rGed82385135cc: pf: fix state leak.Sep 25 2023, 12:27 PM
kp added a commit: rGddca690373e5: pf: fix state leak.

Revision Contents
Changeset List

PathSize
sys/
netpfil/
pf/
26 lines

Diff 127209

View Options

sys/netpfil/pf/pf.c

Loading...