Page MenuHomeFreeBSD
Differential D41688

cxgbe tom: Call t4_rcvd_locked from do_rx_data to return RX credits
ClosedPublic
Actions

Authored by jhb on Sep 1 2023, 9:21 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Oct 13, 9:26 PM
Unknown Object (File)
Mon, Oct 13, 9:26 PM
Unknown Object (File)
Mon, Oct 13, 9:26 PM
Unknown Object (File)
Mon, Oct 13, 7:51 AM
Unknown Object (File)
Sun, Oct 12, 11:12 AM
Unknown Object (File)
Sat, Oct 11, 2:33 AM
Unknown Object (File)
Fri, Oct 10, 10:05 AM
Unknown Object (File)
Wed, Oct 8, 8:17 AM
View All 69 Files
Subscribers
ae
imp

Details

Reviewers
np
Commits
rG7916bb5cdf86: cxgbe tom: Call t4_rcvd_locked from do_rx_data to return RX credits
rGa2128fd12d6e: cxgbe tom: Call t4_rcvd_locked from do_rx_data to return RX credits
rGbd8cecc466ad: cxgbe tom: Call t4_rcvd_locked from do_rx_data to return RX credits
rGdcfddc8dc091: cxgbe tom: Call t4_rcvd_locked from do_rx_data to return RX credits
Summary

In particular, the kernel RPC layer used by the NFS client never
invokes pru_rcvd since it always reads data from the socket upcall
via MSG_SOCALLBCK which avoids calling pru_rcvd. As a result, on an
NFS client connection managed by t4_tom, RX credits were never
returned to the TOE connection to open the TCP window resulting in
connection hangs.

To fix, expand the set of conditions in do_rx_data where RX credits
are returned to match those in t4_rcvd_locked by calling the function
directly.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
sys/
dev/
cxgbe/
tom/
9 lines

Diff 127151

View Options

sys/dev/cxgbe/tom/t4_cpl_io.c

Loading...