Page MenuHomeFreeBSD

audio/mumble: switch from USE_GITHUB to pre-rolled release and fix build on ARCHes other than x86
ClosedPublic

Authored by vvd on Aug 26 2023, 5:48 PM.
Referenced Files
F87409903: D41604.id126600.diff
Tue, Jul 2, 5:17 PM
Unknown Object (File)
Sat, Jun 29, 3:40 AM
Unknown Object (File)
Thu, Jun 27, 10:23 PM
Unknown Object (File)
Tue, Jun 25, 12:37 AM
Unknown Object (File)
Mon, Jun 24, 4:33 PM
Unknown Object (File)
Sun, Jun 23, 4:04 AM
Unknown Object (File)
May 21 2024, 4:44 AM
Unknown Object (File)
May 18 2024, 10:30 AM

Details

Summary
  1. Switch from USE_GITHUB to pre-rolled release.
  2. Use CMake to install the files instead of using custom do-install target.
  3. Unbundle devel/microsoft-gsl.
  4. Fix build and keep possibility to build 32bit overlay on other ARCHes than x86.
  5. "Pet portclippy".

PR:
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=273203
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=272881

Tested build in poudriere on 12.4, 13.2 amd64 and i386. Tested work on 13.2 amd64.

Ideas, patches and testing: fuz@, jhale@, pkubaj@.

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

vvd requested review of this revision.Aug 26 2023, 5:48 PM
vvd created this revision.
diizzy added inline comments.
audio/mumble/Makefile
9

+= should be =

40

Where is this used?

48

+= --> =

vvd marked 3 inline comments as done.Aug 27 2023, 12:58 PM
vvd added inline comments.
audio/mumble/Makefile
40

File auxiliary_files/run_scripts/mumble-overlay.in installed as bin/mumble-overlay.
Check pkg-plist.

vvd marked an inline comment as done.Aug 27 2023, 1:00 PM

Replaced shebang with statically patch.

audio/mumble/files/patch-auxiliary__files_run__scripts_mumble-overlay.in
19

^ thanks, I think this is much cleaner this way than when using shebangfix -- as you already have a nice comment above about removing bash :)

This revision is now accepted and ready to land.Aug 28 2023, 6:31 PM