Page MenuHomeFreeBSD

nvidia-drm-kmod: Update with fix for PRIME
ClosedPublic

Authored by ashafer_badland.io on Aug 24 2023, 8:16 PM.
Tags
None
Referenced Files
Unknown Object (File)
May 11 2024, 9:28 AM
Unknown Object (File)
May 11 2024, 9:22 AM
Unknown Object (File)
May 11 2024, 9:22 AM
Unknown Object (File)
May 8 2024, 3:32 AM
Unknown Object (File)
May 4 2024, 3:37 PM
Unknown Object (File)
Apr 29 2024, 1:58 AM
Unknown Object (File)
Apr 26 2024, 1:33 AM
Unknown Object (File)
Apr 26 2024, 1:32 AM

Details

Summary

This updates the nvidia-drm ports to contain the fix for
https://github.com/amshafer/nvidia-driver/issues/20

Also updates the port Makefiles to use CONFLICTS_INSTALL to resolve
PR 273261, and adds PORTREVISION to the github tag referenced.

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

graphics/nvidia-drm-kmod/Makefile.common
18

Why change this? I find ${PORTNAME}-${PORTVERSION} more clear.

Using PKGNAME lets me include the PORTREVISION in addition to the previous fields. That way it will look for tags such as nvidia-drm-515-kmod-535.98_1 instead of nvidia-drm-515-kmod-535.98. This seemed like the easiest way to do this.

Using PKGNAME lets me include the PORTREVISION in addition to the previous fields. That way it will look for tags such as nvidia-drm-515-kmod-535.98_1 instead of nvidia-drm-515-kmod-535.98. This seemed like the easiest way to do this.

Hmm, tags reflecting PORTREVISIONs is a rarity by itself, so I'm not sure what's best to do there. Don't you like explicit ${PORTNAME}-${PORTVERSION}${PORTREVISION:C/[1-9]/_&/1:C/0//} more?

haha that certainly looks a bit more complicated :)

Unless there's a good technical reason I think PKGNAME is easier for me in the future when I forget how this works and have to read it again.

haha that certainly looks a bit more complicated :)

Unless there's a good technical reason I think PKGNAME is easier for me in the future when I forget how this works and have to read it again.

Afair PORTREVISION will be included in PKGNAME, and you likely do not want that :) -- to elaborate: someone else might bump PORTREVISION due to unrelated changes, and so it should not be part of anything "static".

This revision is now accepted and ready to land.Sep 1 2023, 4:15 PM
This revision was automatically updated to reflect the committed changes.