Paths

Table of Contentst

Differential D41543

libzstd: Explicitly define ZSTD_DISABLE_ASM
ClosedPublic
Actions

Authored by jrtc27 on Aug 22 2023, 2:58 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Feb 15, 6:12 PM

	Unknown Object (File)
	Wed, Feb 5, 6:43 AM

	Unknown Object (File)
	Tue, Feb 4, 11:14 AM

	Unknown Object (File)
	Tue, Feb 4, 4:18 AM

	Unknown Object (File)
	Sun, Jan 26, 4:29 PM

	Unknown Object (File)
	Sat, Jan 25, 1:49 PM

	Unknown Object (File)
	Jan 17 2025, 9:05 AM

	Unknown Object (File)
	Jan 10 2025, 12:17 PM

View All 45 Files

Subscribers

None

Details

Reviewers

dim
emaste
imp

Commits

rG4101bcfa18c0: libzstd: Explicitly define ZSTD_DISABLE_ASM

Summary

On FreeBSD, ZSTD_ASM_SUPPORTED is defined as 0, but on macOS and Linux
it is defined as 1, yet we don't build any of the assembly sources.
Rather than add them just for bootstrapping on non-FreeBSD, explicitly
define ZSTD_DISABLE_ASM so they're not needed and everything is
consistent.

This fixes building a bootstrap LLVM toolchain on non-FreeBSD amd64 (the
only architecture with assembly available).

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jrtc27 requested review of this revision.Aug 22 2023, 2:58 AM

jrtc27 created this revision.

Harbormaster completed remote builds in B53225: Diff 126351.Aug 22 2023, 2:58 AM

I wonder why ZSTD_ASM_SUPPORTED is 0 on FreeBSD

This revision is now accepted and ready to land.Aug 22 2023, 3:17 AM

In D41543#946644, @emaste wrote:

I wonder why ZSTD_ASM_SUPPORTED is 0 on FreeBSD

¯\_(ツ)_/¯

imp accepted this revision.Aug 22 2023, 5:23 PM

Closed by commit rG4101bcfa18c0: libzstd: Explicitly define ZSTD_DISABLE_ASM (authored by jrtc27). · Explain WhyAug 22 2023, 8:03 PM

This revision was automatically updated to reflect the committed changes.

jrtc27 added a commit: rG4101bcfa18c0: libzstd: Explicitly define ZSTD_DISABLE_ASM.

Revision Contents
Changeset List

Path

Size

lib/

libzstd/

5 lines

Diff 126396

lib/libzstd/Makefile

Loading...