Differential D41533

arm unwind: Reject unaligned stack pointers
ClosedPublic
Actions

Authored by jhb on Aug 21 2023, 10:04 PM.

Tags

None

Referenced Files

	F137925757: D41533.id126335.diff
	Thu, Nov 27, 7:58 AM

	Unknown Object (File)
	Tue, Nov 25, 6:03 PM

	Unknown Object (File)
	Sun, Nov 23, 7:54 PM

	Unknown Object (File)
	Sat, Nov 22, 8:15 AM

	Unknown Object (File)
	Sun, Nov 9, 12:51 AM

	Unknown Object (File)
	Thu, Nov 6, 10:17 PM

	Unknown Object (File)
	Tue, Nov 4, 12:21 PM

	Unknown Object (File)
	Tue, Nov 4, 12:17 PM

View All 85 Files

Subscribers

Details

Reviewers

andrew
manu

Commits

rG0b76796abdc8: arm unwind: Reject unaligned stack pointers
rGf9984cda9609: arm unwind: Reject unaligned stack pointers
rG247e8662d2c0: arm unwind: Reject unaligned stack pointers

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Aug 21 2023, 10:04 PM

Herald added a subscriber: imp. · View Herald TranscriptAug 21 2023, 10:04 PM

jhb requested review of this revision.Aug 21 2023, 10:04 PM

Harbormaster completed remote builds in B53215: Diff 126335.Aug 21 2023, 10:04 PM

andrew added inline comments.Aug 22 2023, 8:55 AM

sys/arm/arm/unwind.c
404–405	The comment is probably unneeded but is also unrelated to this change. It's for setting the variable to see if we need to update the saved stack pointer before returning success.

Move before comment

Harbormaster completed remote builds in B53241: Diff 126379.Aug 22 2023, 5:08 PM

andrew accepted this revision.Aug 22 2023, 5:52 PM

This revision is now accepted and ready to land.Aug 22 2023, 5:52 PM

Closed by commit rG247e8662d2c0: arm unwind: Reject unaligned stack pointers (authored by jhb). · Explain WhyAug 25 2023, 7:01 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG247e8662d2c0: arm unwind: Reject unaligned stack pointers.

jhb added a commit: rGf9984cda9609: arm unwind: Reject unaligned stack pointers.Oct 11 2023, 3:45 PM

jhb added a commit: rG0b76796abdc8: arm unwind: Reject unaligned stack pointers.Oct 11 2023, 7:06 PM

Revision Contents
Changeset List

Path

Size

sys/

arm/

arm/

9 lines

Diff 126522

sys/arm/arm/unwind.c

Loading...