Page MenuHomeFreeBSD

forkpty: Avoid fd leak if fork() fails.
ClosedPublic

Authored by des on Aug 17 2023, 1:38 PM.
Tags
None
Referenced Files
F86617980: D41491.id126124.diff
Sun, Jun 23, 2:54 AM
Unknown Object (File)
Sun, Jun 16, 8:06 AM
Unknown Object (File)
Sun, Jun 2, 7:28 PM
Unknown Object (File)
May 23 2024, 1:31 AM
Unknown Object (File)
May 21 2024, 7:04 AM
Unknown Object (File)
May 10 2024, 3:40 AM
Unknown Object (File)
May 9 2024, 10:40 PM
Unknown Object (File)
May 9 2024, 7:42 AM

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

des requested review of this revision.Aug 17 2023, 1:38 PM
allanjude added a subscriber: allanjude.

Reviewed-by: allanjude

This revision is now accepted and ready to land.Aug 17 2023, 1:43 PM
This revision was automatically updated to reflect the committed changes.
markj added inline comments.
lib/libutil/tests/forkpty_test.c
31

This affects all processes with the same UID, right? If so, the setting could cause transient failures for a user running the tests.

Though, contrib/netbsd-tests/lib/libc/sys/t_setrlimit.c does the same thing, and it doesn't appear to cause problems, so perhaps I'm missing something.

des marked an inline comment as done.Aug 17 2023, 2:43 PM
des added inline comments.
lib/libutil/tests/forkpty_test.c
31

The count is global but the limit only applies to the current process and its descendants.

des marked an inline comment as done.Aug 17 2023, 2:43 PM