Differential D41491

forkpty: Avoid fd leak if fork() fails.
ClosedPublic
Actions

Authored by des on Aug 17 2023, 1:38 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Aug 1, 1:32 PM

	Unknown Object (File)
	Thu, Jul 24, 6:32 AM

	Unknown Object (File)
	Jul 12 2025, 11:47 PM

	Unknown Object (File)
	Jul 5 2025, 12:52 PM

	Unknown Object (File)
	Jul 5 2025, 11:24 AM

	Unknown Object (File)
	Jul 4 2025, 12:42 AM

	Unknown Object (File)
	Jul 3 2025, 5:30 PM

	Unknown Object (File)
	Jun 26 2025, 8:10 PM

View All 79 Files

Subscribers

Details

Reviewers

Commits

rG1fb1008822c6: forkpty: Avoid fd leak if fork() fails.
rGa4aaee2120ce: forkpty: Avoid fd leak if fork() fails.

Summary

MFC after: 1 week
Sponsored by: Klara, Inc.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

des created this revision.Aug 17 2023, 1:38 PM

Herald added a subscriber: imp. · View Herald TranscriptAug 17 2023, 1:38 PM

des requested review of this revision.Aug 17 2023, 1:38 PM

Harbormaster completed remote builds in B53151: Diff 126123.Aug 17 2023, 1:38 PM

Reviewed-by: allanjude

This revision is now accepted and ready to land.Aug 17 2023, 1:43 PM

Closed by commit rGa4aaee2120ce: forkpty: Avoid fd leak if fork() fails. (authored by des). · Explain WhyAug 17 2023, 1:49 PM

This revision was automatically updated to reflect the committed changes.

des added a commit: rGa4aaee2120ce: forkpty: Avoid fd leak if fork() fails..

markj added a subscriber: markj.Aug 17 2023, 1:55 PM

markj added inline comments.

lib/libutil/tests/forkpty_test.c
31	This affects all processes with the same UID, right? If so, the setting could cause transient failures for a user running the tests. Though, contrib/netbsd-tests/lib/libc/sys/t_setrlimit.c does the same thing, and it doesn't appear to cause problems, so perhaps I'm missing something.

des marked an inline comment as done.Aug 17 2023, 2:43 PM

des added inline comments.

lib/libutil/tests/forkpty_test.c
31	The count is global but the limit only applies to the current process and its descendants.

des marked an inline comment as done.Aug 17 2023, 2:43 PM

des added a commit: rG1fb1008822c6: forkpty: Avoid fd leak if fork() fails..Sep 7 2023, 5:31 PM

Revision Contents
Changeset List

Path

Size

lib/

libutil/

1 line

tests/

1 line

58 lines

Diff 126124

lib/libutil/pty.c

Loading...

lib/libutil/tests/Makefile

Loading...

lib/libutil/tests/forkpty_test.c

Loading...