Page MenuHomeFreeBSD

forkpty: Avoid fd leak if fork() fails.
ClosedPublic

Authored by des on Aug 17 2023, 1:38 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Sep 30, 6:54 PM
Unknown Object (File)
Tue, Sep 30, 10:24 AM
Unknown Object (File)
Tue, Sep 30, 9:36 AM
Unknown Object (File)
Tue, Sep 30, 8:32 AM
Unknown Object (File)
Fri, Sep 26, 7:55 PM
Unknown Object (File)
Thu, Sep 18, 1:18 PM
Unknown Object (File)
Sep 15 2025, 3:57 PM
Unknown Object (File)
Sep 6 2025, 6:32 PM

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

des requested review of this revision.Aug 17 2023, 1:38 PM
allanjude added a subscriber: allanjude.

Reviewed-by: allanjude

This revision is now accepted and ready to land.Aug 17 2023, 1:43 PM
This revision was automatically updated to reflect the committed changes.
markj added inline comments.
lib/libutil/tests/forkpty_test.c
31

This affects all processes with the same UID, right? If so, the setting could cause transient failures for a user running the tests.

Though, contrib/netbsd-tests/lib/libc/sys/t_setrlimit.c does the same thing, and it doesn't appear to cause problems, so perhaps I'm missing something.

des marked an inline comment as done.Aug 17 2023, 2:43 PM
des added inline comments.
lib/libutil/tests/forkpty_test.c
31

The count is global but the limit only applies to the current process and its descendants.

des marked an inline comment as done.Aug 17 2023, 2:43 PM