Differential D41405

Update comment describing vm_map
ClosedPublic
Actions

Authored by kib on Aug 10 2023, 5:05 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	May 1 2024, 11:36 PM

	Unknown Object (File)
	May 1 2024, 11:36 PM

	Unknown Object (File)
	May 1 2024, 11:34 PM

	Unknown Object (File)
	May 1 2024, 11:32 PM

	Unknown Object (File)
	May 1 2024, 8:21 PM

	Unknown Object (File)
	Jan 28 2024, 11:56 AM

	Unknown Object (File)
	Jan 12 2024, 6:17 AM

	Unknown Object (File)
	Dec 20 2023, 7:57 AM

View All 16 Files

Subscribers

Details

Reviewers

dougm
alc
markj

Commits

rG9da33e8d1073: Update comment describing struct vm_map

Summary

There is no list connecting all entries any more, and correspondingly no order on the list entries.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kib created this revision.Aug 10 2023, 5:05 AM

Herald added a subscriber: imp. · View Herald TranscriptAug 10 2023, 5:05 AM

kib requested review of this revision.Aug 10 2023, 5:05 AM

dougm added inline comments.Aug 10 2023, 5:41 AM

sys/vm/vm_map.h
186	I agree that "The tree is" should replace "Both structures are", since one of the two structures mentioned in the original comment, the linked-list, disappeared when the tree became threaded. But I don't understand how the tree is no longer threaded. A threaded binary search tree is one where a node with no left child points with its left pointer to its leftmost ancestor, instead of NULL, and similarly for right children and ancestors. I don't think that has changed.

kib marked an inline comment as done.Aug 10 2023, 5:57 AM

kib added inline comments.

sys/vm/vm_map.h
186	I thought 'threaded' referred to the list linked all entries.

kib updated this revision to Diff 125799.Aug 10 2023, 5:58 AM

kib marked an inline comment as done.

kib edited the summary of this revision. (Show Details)

dougm accepted this revision.Aug 10 2023, 5:59 AM

This revision is now accepted and ready to land.Aug 10 2023, 5:59 AM

Closed by commit rG9da33e8d1073: Update comment describing struct vm_map (authored by kib). · Explain WhyAug 10 2023, 6:02 AM

This revision was automatically updated to reflect the committed changes.

kib added a commit: rG9da33e8d1073: Update comment describing struct vm_map.

Revision Contents
Changeset List

Path

Size

sys/

vm/

7 lines

Diff 125800

sys/vm/vm_map.h

Loading...