Page MenuHomeFreeBSD
Differential D41107

ifconfig: Fix the display of capabilities in the netlink based code.
ClosedPublic
Actions

Authored by np on Jul 20 2023, 1:26 AM.
Tags
None
Referenced Files
F82768088: D41107.id.diff
Thu, May 2, 10:38 AM
F82768082: D41107.id124895.diff
Thu, May 2, 10:38 AM
F82763994: D41107.id124927.diff
Thu, May 2, 9:43 AM
Unknown Object (File)
Thu, May 2, 9:09 AM
Unknown Object (File)
Sat, Apr 27, 5:50 AM
Unknown Object (File)
Mar 13 2024, 2:58 AM
Unknown Object (File)
Mar 13 2024, 2:28 AM
Unknown Object (File)
Dec 23 2023, 12:15 AM
View All 16 Files
Subscribers
imp

Details

Reviewers
kib
melifaro
jhb
Commits
rG47b1fef6fb22: ifconfig: Fix the display of capabilities in the netlink based code.
Summary

The capabilities in if_capabilities2/if_capenable2 that don't fit in the
first 32b were not being displayed correctly. v does not need to be
advanced because v[i / 32] is the correct uint32_t already.

Sponsored by: Chelsio Communications

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

np created this revision.Jul 20 2023, 1:26 AM
Herald added a subscriber: imp. · View Herald TranscriptJul 20 2023, 1:26 AM
np requested review of this revision.Jul 20 2023, 1:26 AM
Harbormaster completed remote builds in B52735: Diff 124895.Jul 20 2023, 1:26 AM
np added a comment.Jul 20 2023, 1:28 AM

I am experimenting with some additional caps that use bits in capabilities2/capenable2 and that's how I ran into this.

kib accepted this revision.Jul 20 2023, 9:44 AM
kib added inline comments.
sbin/ifconfig/ifconfig_netlink.c
90

btw i should have unsigned type, otherwise i<<31 is UB

This revision is now accepted and ready to land.Jul 20 2023, 9:44 AM
np added inline comments.Jul 20 2023, 5:27 PM
sbin/ifconfig/ifconfig_netlink.c
90

i is not shifted anywhere in this routine.

Closed by commit rG47b1fef6fb22: ifconfig: Fix the display of capabilities in the netlink based code. (authored by np). · Explain WhyJul 20 2023, 5:28 PM
This revision was automatically updated to reflect the committed changes.
np added a commit: rG47b1fef6fb22: ifconfig: Fix the display of capabilities in the netlink based code..
kib added inline comments.Jul 20 2023, 5:39 PM
sbin/ifconfig/ifconfig_netlink.c
90

Err, yes. the line above should use 1U instead of 1.

Revision Contents
Changeset List

PathSize
sbin/
ifconfig/
2 lines

Diff 124927

View Options

sbin/ifconfig/ifconfig_netlink.c

Loading...