Differential D41082

cam/scsi: Better action for ASC/ASCQ 0x18/0x08
ClosedPublic
Actions

Authored by imp on Jul 19 2023, 4:15 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Feb 25, 3:04 PM

	Unknown Object (File)
	Feb 10 2025, 1:56 PM

	Unknown Object (File)
	Feb 5 2025, 8:33 AM

	Unknown Object (File)
	Jan 27 2025, 7:15 PM

	Unknown Object (File)
	Jan 26 2025, 6:16 PM

	Unknown Object (File)
	Jan 25 2025, 5:04 PM

	Unknown Object (File)
	Jan 24 2025, 6:00 PM

	Unknown Object (File)
	Jan 24 2025, 5:39 PM

View All 37 Files

Subscribers

None

Details

Reviewers

jhb
mav

Group Reviewers

Commits

rG367699ca7ac7: cam/scsi: Better action for ASC/ASCQ 0x18/0x08

Summary

0x18/0x8 is another code to indicate that the data was recovered
successfully, so complete the command w/o an error rather than retry the
operation.

Sponsored by: Netflix

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

imp created this revision.Jul 19 2023, 4:15 AM

Herald added a reviewer: cam. · View Herald TranscriptJul 19 2023, 4:15 AM

imp requested review of this revision.Jul 19 2023, 4:15 AM

Harbormaster completed remote builds in B52707: Diff 124830.Jul 19 2023, 4:15 AM

imp added a parent revision: D41081: cam: Add comment about recovery ccbs.Jul 19 2023, 4:15 AM

imp added a child revision: D41083: cam: Be explict about CAM_SMP_STATUS_ERROR.

I don't know what is the "linking", but can believe.

This revision is now accepted and ready to land.Jul 19 2023, 2:19 PM

jhb accepted this revision.Jul 19 2023, 5:57 PM

Closed by commit rG367699ca7ac7: cam/scsi: Better action for ASC/ASCQ 0x18/0x08 (authored by imp). · Explain WhyJul 21 2023, 4:32 AM

This revision was automatically updated to reflect the committed changes.

imp added a commit: rG367699ca7ac7: cam/scsi: Better action for ASC/ASCQ 0x18/0x08.

Revision Contents
Changeset List

Path

Size

sys/

cam/

scsi/

2 lines

Diff 124954

sys/cam/scsi/scsi_all.c

This file is larger than 256 KB, so syntax highlighting is disabled by default.

	Show First 20 Lines • Show All 1,586 Lines • ▼ Show 20 Lines		/* D WRO BK */
	"Recovered data - recommend reassignment") },			"Recovered data - recommend reassignment") },
	/* D WRO BK */			/* D WRO BK */
	{ SST(0x18, 0x06, SS_NOP \| SSQ_PRINT_SENSE,			{ SST(0x18, 0x06, SS_NOP \| SSQ_PRINT_SENSE,
	"Recovered data - recommend rewrite") },			"Recovered data - recommend rewrite") },
	/* D W O BK */			/* D W O BK */
	{ SST(0x18, 0x07, SS_NOP \| SSQ_PRINT_SENSE,			{ SST(0x18, 0x07, SS_NOP \| SSQ_PRINT_SENSE,
	"Recovered data with ECC - data rewritten") },			"Recovered data with ECC - data rewritten") },
	/* R */			/* R */
	{ SST(0x18, 0x08, SS_RDEF, /* XXX TBD */			{ SST(0x18, 0x08, SS_NOP \| SSQ_PRINT_SENSE,
	"Recovered data with linking") },			"Recovered data with linking") },
	/* D O K */			/* D O K */
	{ SST(0x19, 0x00, SS_RDEF,			{ SST(0x19, 0x00, SS_RDEF,
	"Defect list error") },			"Defect list error") },
	/* D O K */			/* D O K */
	{ SST(0x19, 0x01, SS_RDEF,			{ SST(0x19, 0x01, SS_RDEF,
	"Defect list not available") },			"Defect list not available") },
	/* D O K */			/* D O K */
	▲ Show 20 Lines • Show All 7,828 Lines • Show Last 20 Lines