Page MenuHomeFreeBSD

Mk/bsd.options.desc.mk: add "PIPEWIRE_DESC?= PipeWire multimedia server support"
ClosedPublic

Authored by vvd on Jul 14 2023, 3:05 PM.
Referenced Files
Unknown Object (File)
Sat, Jun 22, 2:05 PM
Unknown Object (File)
Wed, Jun 5, 11:40 PM
Unknown Object (File)
Tue, May 28, 8:14 AM
Unknown Object (File)
May 23 2024, 4:03 PM
Unknown Object (File)
May 13 2024, 1:35 AM
Unknown Object (File)
May 8 2024, 9:35 PM
Unknown Object (File)
May 4 2024, 9:36 PM
Unknown Object (File)
May 4 2024, 12:45 PM
Subscribers

Details

Summary

Ports affected:
audio/fluidsynth
audio/musicpd
devel/sdl20
multimedia/audacious-plugins
multimedia/kodi
multimedia/mpv
multimedia/qmmp-qt5
multimedia/qmmp-qt6

Keep custom description:
graphics/spectacle
multimedia/obs-studio
net/krfb
x11-wm/gamescope

Added all maintainers as Reviewers except multimedia/kodi yzrh@noema.org.

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

vvd requested review of this revision.Jul 14 2023, 3:05 PM
vvd created this revision.
vvd retitled this revision from Mk/bsd.options.desc.mk: add "PIPEWIRE_DESC?= PipeWire multimedia server support to Mk/bsd.options.desc.mk: add "PIPEWIRE_DESC?= PipeWire multimedia server support".Jul 14 2023, 3:13 PM
vvd edited the summary of this revision. (Show Details)
vvd added a project: multimedia.
graphics/spectacle/Makefile
29 ↗(On Diff #124680)

This should probably stay, as it is more accurate. It clearly explains what's pipewire is used for.

multimedia/obs-studio/Makefile
96 ↗(On Diff #124680)

Same here.

net/krfb/Makefile
26 ↗(On Diff #124680)

Here.

x11-wm/gamescope/Makefile
49 ↗(On Diff #124680)

And here.

This should probably stay, as it is more accurate. It clearly explains what's pipewire is used for.

I assumed this, but wanted to hear the views of the maintainers.

I agree with arrowd@

Mk/bsd.options.desc.mk
502

This unrelated in shouldn't be covered in this commit

Mk/bsd.options.desc.mk
502

Ok.
I will make a separate review for tomcats and update this review when I get all the comments.

Mk/bsd.options.desc.mk
502

Apparently it's not a great idea to try using your phone for this ;-)
At least you got my point =)

vvd edited the summary of this revision. (Show Details)
vvd marked 2 inline comments as done.
vvd marked 4 inline comments as done.Jul 15 2023, 12:41 PM
This revision is now accepted and ready to land.Jul 15 2023, 9:55 PM

@vvd You can remove PIPEWIRE_DESC lines in ports that are essentially the same as a generic one, and keep the ones that are different/more specific.
Ports can define their own descriptions for options when they are more informative than the generic one.