Differential D41028

memdesc: Add a MEMDESC_VMPAGES descriptor type.
ClosedPublic
Actions

Authored by jhb on Jul 13 2023, 9:45 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	May 2 2024, 12:47 PM

	Unknown Object (File)
	May 2 2024, 12:47 PM

	Unknown Object (File)
	May 2 2024, 11:08 AM

	Unknown Object (File)
	May 2 2024, 10:37 AM

	Unknown Object (File)
	Dec 28 2023, 1:43 PM

	Unknown Object (File)
	Dec 23 2023, 7:51 AM

	Unknown Object (File)
	Dec 20 2023, 6:53 AM

	Unknown Object (File)
	Dec 12 2023, 3:37 AM

View All 16 Files

Subscribers

None

Details

Reviewers

markj
imp
kib

Commits

rGbab38b44dd11: memdesc: Add a MEMDESC_VMPAGES descriptor type.

Summary

This memory descriptor is backed by an array of VM pages. This type
requires adding a new field to 'struct memdesc' to hold the offset
within the first page. For LP64 systems, this new field is added in
an existing padding hole so does not increase the size. For ILP32
systems, this grows 'struct memdesc' from 12 to 16 bytes.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb requested review of this revision.Jul 13 2023, 9:45 PM

jhb created this revision.

Harbormaster completed remote builds in B52630: Diff 124636.Jul 13 2023, 9:45 PM

jhb added a parent revision: D41027: memdesc: Replace md_opaque with a union of type-specific fields..Jul 13 2023, 9:45 PM

jhb added a child revision: D41029: memdesc: Retire MEMDESC_BIO..

imp accepted this revision.Jul 13 2023, 11:11 PM

This revision is now accepted and ready to land.Jul 13 2023, 11:11 PM

markj accepted this revision.Jul 14 2023, 1:38 PM

markj added inline comments.

sys/sys/memdesc.h
65	I'd put the two unions back-to-back in the struct, just because they're both fields which describe the buffer layout in some type-specific way.

jhb marked an inline comment as done.Jul 14 2023, 5:40 PM

Closed by commit rGbab38b44dd11: memdesc: Add a MEMDESC_VMPAGES descriptor type. (authored by jhb). · Explain WhyJul 14 2023, 6:42 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rGbab38b44dd11: memdesc: Add a MEMDESC_VMPAGES descriptor type..

Revision Contents
Changeset List

Path

Size

sys/

kern/

4 lines

sys/

21 lines

Diff 124688

sys/kern/subr_bus_dma.c

Loading...

sys/sys/memdesc.h

Loading...