www/madsonic: update to 6.2.9092 and sort out Makefile
ClosedPublic
Actions

Authored by vvd on Jul 13 2023, 1:18 PM.

Details

Reviewers

arrowd
tcberner
adamw

Commits

R11:c165fd3011c0: www/madsonic: update to 6.2.9092 and sort out Makefile
R11:3d6c1cd815df: www/madsonic: update to 6.2.9092 and sort out Makefile

Summary

Found this port depends on EOLed and removed from ports www/tomcat7 and "freshed" it.

Update to 6.2.9092.
Replace option TOMCAT7 with TOMCAT85.
Remove option RESIN3: "www/resin3||2023-05-06|Deprecated version, unsupported by upstream for years".
"Sort out" Makefile - portlint is happy.

Tested build in poudriere: 12.4, 13.1, 13.2 amd64 and i386. With JETTY8 and TOMCAT85 options ON. With and without all other optional options.

But run is not tested.

P.S. This port have no maintainer.

Diff Detail

Repository

R11 FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

vvd requested review of this revision.Jul 13 2023, 1:18 PM

vvd created this revision.

arrowd accepted this revision.Jul 13 2023, 5:37 PM

arrowd added inline comments.

www/madsonic/Makefile
24	Why does this port have `pkg-plist` renamed to `plist`?

This revision is now accepted and ready to land.Jul 13 2023, 5:37 PM

vvd marked an inline comment as done.Jul 13 2023, 6:00 PM

vvd added inline comments.

www/madsonic/Makefile
24	It generated everytime time in pre-install: https://cgit.freebsd.org/ports/tree/www/madsonic/Makefile#n107

Closed by commit R11:3d6c1cd815df: www/madsonic: update to 6.2.9092 and sort out Makefile (authored by vvd). · Explain WhyJul 13 2023, 6:08 PM

This revision was automatically updated to reflect the committed changes.

vvd marked an inline comment as done.

vvd added a commit: R11:3d6c1cd815df: www/madsonic: update to 6.2.9092 and sort out Makefile.

vvd added a commit: R11:c165fd3011c0: www/madsonic: update to 6.2.9092 and sort out Makefile.

Ugh, nasty. The correct way to do this is to append to ${TMPPLIST} file on the *-install stage.

In D41017#933707, @arrowd wrote:

Ugh, nasty. The correct way to do this is to append to ${TMPPLIST} file on the *-install stage.

Probably. But I'm here to fix dependencies from EOLed tomcat and resin + sort options only.
Rewrite Makefile is more complex task.
And I'm not using this port.

If we find users of this port then maybe we find maintainer and fix this too.