Page MenuHomeFreeBSD
Differential D41012

kern.post.mk allow NEWVERS_{ENV,ARGS}
ClosedPublic
Actions

Authored by sjg on Jul 12 2023, 7:30 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Feb 28, 7:52 PM
Unknown Object (File)
Sat, Feb 22, 1:17 PM
Unknown Object (File)
Feb 18 2025, 9:29 PM
Unknown Object (File)
Feb 17 2025, 1:13 PM
Unknown Object (File)
Feb 10 2025, 12:52 AM
Unknown Object (File)
Jan 27 2025, 5:15 AM
Unknown Object (File)
Jan 27 2025, 5:15 AM
Unknown Object (File)
Jan 26 2025, 8:24 AM
View All 40 Files
Subscribers
None

Details

Reviewers
imp
emaste
stevek
Commits
rG89f361f742ae: kern.post.mk allow NEWVERS_{ENV,ARGS}
Summary

Allow makefiles better control of newvers.sh env and args.
Also allow variable overrides on command line.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

sjg requested review of this revision.Jul 12 2023, 7:30 PM
sjg created this revision.
Harbormaster completed remote builds in B52608: Diff 124591.Jul 12 2023, 7:30 PM
imp accepted this revision.Jul 17 2023, 6:17 PM
This revision is now accepted and ready to land.Jul 17 2023, 6:17 PM
Closed by commit rG89f361f742ae: kern.post.mk allow NEWVERS_{ENV,ARGS} (authored by sjg). · Explain WhyJul 17 2023, 7:04 PM
This revision was automatically updated to reflect the committed changes.
sjg added a commit: rG89f361f742ae: kern.post.mk allow NEWVERS_{ENV,ARGS}.

Revision Contents
Changeset List

PathSize
sys/
conf/
5 lines
16 lines

Diff 124782

View Options

sys/conf/kern.post.mk

Show First 20 Lines • Show All 680 Lines • ▼ Show 20 Lineszfsctl_root_readdir(struct vop_readdir_args *ap)
/* /*
* FIXME: this routine only ever emits 3 entries and does not tolerate * FIXME: this routine only ever emits 3 entries and does not tolerate
* being called with a buffer too small to handle all of them. * being called with a buffer too small to handle all of them.
* *
* The check below facilitates the idiom of repeating calls until the * The check below facilitates the idiom of repeating calls until the
* count to return is 0. * count to return is 0.
*/ */
if (zfs_uio_offset(&uio) == 3 * sizeof(entry)) { if (zfs_uio_offset(&uio) == 3 * sizeof (entry)) {
jhbAuthorUnsubmitted
Done
Inline Actions

Possibly this should be fixed upstream instead, but having it as a local diff is needless.

jhb: Possibly this should be fixed upstream instead, but having it as a local diff is needless.
emasteUnsubmitted
Not Done
Inline Actions

I see 57 files with sizeof( and 385 with sizeof ( upstream (some files might have both styles and be double-counted) so it looks like our local diff is contrary to upstream's preferred style.

emaste: I see 57 files with `sizeof(` and 385 with `sizeof (` upstream (some files might have both…
return (0); return (0);
} }
error = sfs_readdir_common(zfsvfs->z_root, ZFSCTL_INO_ROOT, ap, &uio, error = sfs_readdir_common(zfsvfs->z_root, ZFSCTL_INO_ROOT, ap, &uio,
&dots_offset); &dots_offset);
if (error != 0) { if (error != 0) {
if (error == ENAMETOOLONG) /* ran out of destination space */ if (error == ENAMETOOLONG) /* ran out of destination space */
error = 0; error = 0;
▲ Show 20 Lines • Show All 682 Lines • Show Last 20 Lines
View Options

sys/conf/newvers.sh

Show First 20 Lines • Show All 680 Lines • ▼ Show 20 Lineszfsctl_root_readdir(struct vop_readdir_args *ap)
/* /*
* FIXME: this routine only ever emits 3 entries and does not tolerate * FIXME: this routine only ever emits 3 entries and does not tolerate
* being called with a buffer too small to handle all of them. * being called with a buffer too small to handle all of them.
* *
* The check below facilitates the idiom of repeating calls until the * The check below facilitates the idiom of repeating calls until the
* count to return is 0. * count to return is 0.
*/ */
if (zfs_uio_offset(&uio) == 3 * sizeof(entry)) { if (zfs_uio_offset(&uio) == 3 * sizeof (entry)) {
jhbAuthorUnsubmitted
Done
Inline Actions

Possibly this should be fixed upstream instead, but having it as a local diff is needless.

jhb: Possibly this should be fixed upstream instead, but having it as a local diff is needless.
emasteUnsubmitted
Not Done
Inline Actions

I see 57 files with sizeof( and 385 with sizeof ( upstream (some files might have both styles and be double-counted) so it looks like our local diff is contrary to upstream's preferred style.

emaste: I see 57 files with `sizeof(` and 385 with `sizeof (` upstream (some files might have both…
return (0); return (0);
} }
error = sfs_readdir_common(zfsvfs->z_root, ZFSCTL_INO_ROOT, ap, &uio, error = sfs_readdir_common(zfsvfs->z_root, ZFSCTL_INO_ROOT, ap, &uio,
&dots_offset); &dots_offset);
if (error != 0) { if (error != 0) {
if (error == ENAMETOOLONG) /* ran out of destination space */ if (error == ENAMETOOLONG) /* ran out of destination space */
error = 0; error = 0;
▲ Show 20 Lines • Show All 682 Lines • Show Last 20 Lines