Fix the implementations of PSEUDO_NOERROR and PSEUDO.
ClosedPublic
Actions

Authored by brooks on Nov 7 2015, 12:21 AM.

Details

Reviewers

kib
imp
adrian

Commits

rS295020: MFC r294515:
rS294515: Fix the implementations of PSEUDO_NOERROR and PSEUDO.

Summary

The PSEUDO* macros should not declare <syscall>, only _<syscall> and
__sys_<syscall>. This was causing the interposing C wrappers to be
ignored due to link order.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

brooks updated this revision to Diff 10003.Nov 7 2015, 12:21 AM

brooks retitled this revision from to Fix the implementations of PSEUDO_NOERROR and PSEUDO..

brooks updated this object.

brooks edited the test plan for this revision. (Show Details)

brooks added reviewers: adrian, imp.

Without this change, threaded applications don't use mutexes around system calls and threaded programs likely do not work correctly.

brooks added a reviewer: kib.Jan 21 2016, 2:02 AM

Mostly, it was not about mutexes but for working cancellation. It is more complicated for signal-related syscalls, esp. sigaction(2), where the bug could result in non-functional rtld locks.

This revision is now accepted and ready to land.Jan 21 2016, 6:52 AM

Closed by commit rS294515: Fix the implementations of PSEUDO_NOERROR and PSEUDO. (authored by brooks). · Explain WhyJan 21 2016, 5:29 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

lib/

libc/

mips/

SYS.h

28 lines

Diff 12565

View Options

Fix the implementations of PSEUDO_NOERROR and PSEUDO.ClosedPublicActions